PR: 229063
This port should be particularly useful to simplify the scripting for x11/lemonbar users.
Details
Details
Upstream use libc-0.2.37 cargo crate and I got this message:
CARGO_CRATES=libc-0.2.37 or older maybe unstable on FreeBSD 12.0. Consider updating to the latest version.
I do not have any -CURRENT installation and so I patched to updated it to libc-0.2.42 cargo crate.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| x11/admiral/Makefile | ||
|---|---|---|
| 16 ↗ | (On Diff #43860) | The upstream repo has a tag, so follow [1] instead of setting GH_TAGNAME when you need a newer commit. |
| 45–46 ↗ | (On Diff #43860) | Add an EXAMPLES option and add the examples to PORTEXAMPLES instead. |
| 51 ↗ | (On Diff #43860) | Never use ${CP} to install files (see [1]). ${COPYTREE_SHARE} could be useful here, but there seem to be only two files so a regular ${INSTALL_DATA} will probably do. [1] https://www.freebsd.org/doc/en/books/porters-handbook/install.html |
| x11/admiral/files/patch-Cargo.lock | ||
| 1–2 ↗ | (On Diff #43860) | Remove this patch. Cargo will automatically update Cargo.lock when you bump the libc crate in CARGO_CRATES. There is no need to patch it manually. |
| x11/admiral/Makefile | ||
|---|---|---|
| 51 ↗ | (On Diff #43860) | The problem I had while using ${INSTALL_DATA} was an error I assumed happened because I was trying to copy the 'admiral.d' directory instead of the files inside it. The reason is the configuration files should be installed inside a directory called 'admiral.d' and so I want to keep the reference. |
| x11/admiral/Makefile | ||
|---|---|---|
| 51 ↗ | (On Diff #43860) | But thinking about it now I could have created the directory just on the line before. Thanks! :) |
Comment Actions
Done.
I think PLIST_FILES cannot be used when PORTEXAMPLES is set, can you confirm please?
Thanks!
Comment Actions
No, that's not true. You should remove pkg-plist again and just set PLIST_FILES=bin/admiral. What you add to PORTEXAMPLES does not have to appear in PLIST_FILES again.
| x11/admiral/Makefile | ||
|---|---|---|
| 19 ↗ | (On Diff #43881) | This needs to be below CARGO_CRATES. https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html |
Comment Actions
With these changes I get this error message:
Error: Orphaned: %%PORTEXAMPLES%%%%EXAMPLESDIR%%/admiral.toml
Error: Orphaned: %%PORTEXAMPLES%%%%EXAMPLESDIR%%/bspwm_workspaces.sh
I am missing something. :(
Thanks!
| x11/admiral/Makefile | ||
|---|---|---|
| 47–48 ↗ | (On Diff #43885) | Either do not set EXAMPLESDIR or change PORTEXAMPLES. The files in PORTEXAMPLES are supposed to be relative to EXAMPLESDIR but that is not the case now. |
| x11/admiral/Makefile | ||
|---|---|---|
| 55–56 ↗ | (On Diff #44016) | ${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
(cd ${WRKSRC} && ${COPYTREE_SHARE} admiral.d ${STAGEDIR}${EXAMPLESDIR}) |
Comment Actions
It does. But you are not working on files, you are working on directories here. Whenever you are using COPYTREE_SHARE on . and the directory name is the same in the remote location, it is better to let the macro handle the directory creation.
Comment Actions
Fine except for the confusion over "bars"
| x11/admiral/Makefile | ||
|---|---|---|
| 10 ↗ | (On Diff #44047) | "Merge concurrent outputs for a status bar" is shorter and IMO, more to the point. I was wondering why there would be specific applications for drinking establishments -- not until the second sentence of pkg-descr does it become clear that this is for stats-bar applications in window managers. |
| x11/admiral/pkg-descr | ||
| 1 ↗ | (On Diff #44047) | Possibly "status bars" |
| x11/admiral/Makefile | ||
|---|---|---|
| 10 ↗ | (On Diff #44047) | Oh, I was wondering wtf this was doing, but I am so used to COMMENT and pkg-descr being not descriptive unless you already know what it does that I do not comment about it any more. |