Including rc_conf_directories to be loaded with rc(8)

[larafercue_gmail.com]

Summary

rc.conf.d directories contains configuration files to be used at
boot time. This patch allows the user to write configuration files
under /etc/rc.conf.d and being loaded at boot time.

Test Plan

Create configuration files under /etc/rc.conf.d and rebooting to
see if they were loaded. Also changing the rc_conf_dirs to include
/usr/local/etc/rc.conf.d and repeat the process

Sponsored by: Bally Wulff Games & Entertainment GmbH

[rpokala]

etc/defaults/rc.conf

711–716

You're not actually using "sourced_dirs" anywhere.

714

This will find files or directories named f; that's probably not what you intended...

(Perhaps you wanted find ${i} -type f?)

[larafercue_gmail.com]

Removing unused variables and fixing find

[larafercue_gmail.com]

etc/defaults/rc.conf

714

That's actually what I wanted, thanks

[rpokala]

etc/defaults/rc.conf

711–716

Oh, do you need to declare d as a local?

[larafercue_gmail.com]

Declaring d as local variable

[larafercue_gmail.com]

Fixing problems and submitting comments

[larafercue_gmail.com]

Exchanging i and d so d is for directories and i for files. Also including them

[rpokala]

etc/defaults/rc.conf

729–734

Does the new stuff need to be repeated here?

[larafercue_gmail.com]

Repeating the block to catch redefined rc_conf_dirs

[larafercue_gmail.com]

Submitting commits

etc/defaults/rc.conf

729–734

I didn't thought to be needed, but if the variable is defined in the configuration files, it might be a good idea.

[rpokala]

I think this looks good now. Now you can point someone who actually knows `rc' at it. :-)

[dab]

etc/defaults/rc.conf

714

You could save the nested for loops by doing:

for i in $(find ${rc_conf_dirs} -type f) ; do

714

Do you actually want to do a recursive search through the rc_conf_dirs or limit the scope to just a first-level search? To be honest, I'm not sure of the "correct" answer to this, but rc only searches the first level in /etc/rc.d and /usr/local/rc.d for scripts to execute.

714

Do you want to source all files found, or limit to a certain subset, such as only those files that end with ".conf"? I think there is precedent for both. Also, should "dot" files (e.g., /etc/rc.conf.d/.example.conf) be excluded?

714

OK, I think this is my last comment (for now, at least).

Do you want to find and source the files in lexicographic order so that someone could, for example, ensure that /etc/rc.conf.d/00-local.conf was sourced before /etc/rc.conf.d/99-local.conf?

[larafercue_gmail.com]

Adding inline comments to figure out the best way to proceed.

etc/defaults/rc.conf

714

could it be done like this?

for i in $(find -s ${rc_conf_dirs} -type f -depth 1 -name '*.conf' -and -not -name '.*') ; do

Searching only on the first level makes sense, they are a collection of configuration files and, in the case that the user wants to sort them out in folders, they can be searched by overriding the rc_conf_dirs variable.

It also makes sense to sort them out in lexicographic order.

[larafercue_gmail.com]

Adding @brooks because he is in the subversion's property $FreeBSD$

[dab]

etc/defaults/rc.conf

714

Yes, I think that will do it.

[larafercue_gmail.com]

Limiting search to immediates files named '*.conf' not starting with a dot

[larafercue_gmail.com]

[0mp]

1. I'd think that files in rc.conf.d should override what is in $rc_conf_files as they are more specific. Is there a reason why you'd like $rc_conf_files to be able to override files in rc.conf.d instead?
2. This change deserves an update to the manual page.

etc/defaults/rc.conf

705

This comment might require an update to mention rc_conf_dirs as well.

713

-depth 1 should be -maxdepth 1. Otherwise, find(1) is going to iterate over all the subdirectories anyway.

730

-depth 1 should be -maxdepth 1. Otherwise, find(1) is going to iterate over all the subdirectories anyway.

[larafercue_gmail.com]

Updating the script with the new location and including the changes proposed by 0mp

[larafercue_gmail.com]

Remove unused variable

[0mp]

libexec/rc/rc.conf

731 ↗

(On Diff #62339)

BTW, find lives in /usr/bin. For what I understand, it may not be available before /usr/ is mounted.