Page MenuHomeFreeBSD

Name the implementation of brk and sbrk sys_break().
ClosedPublic

Authored by brooks on May 31 2018, 11:28 PM.
Tags
None
Referenced Files
F153525799: D15638.id.diff
Tue, Apr 21, 3:50 PM
F153437066: D15638.id43221.diff
Tue, Apr 21, 4:14 AM
Unknown Object (File)
Sun, Apr 19, 6:15 PM
Unknown Object (File)
Wed, Apr 8, 3:54 PM
Unknown Object (File)
Wed, Apr 8, 8:09 AM
Unknown Object (File)
Mon, Apr 6, 6:41 AM
Unknown Object (File)
Mon, Apr 6, 6:39 AM
Unknown Object (File)
Sun, Apr 5, 2:38 PM
Subscribers

Details

Summary

The break() system call was renamed (several times) starting in v3 AT&T
UNIX when C was invented and break was a language keyword. The last
vestage of a need for it to be called something else (eg obreak) was removed
in r225617 which consistantly prefixed all syscall implementations.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Don't you miss compat32 ?

sys/vm/vm_unix.c
198 ↗(On Diff #43221)

Remove this printf, it is spam.

And capabilities.conf are not handled.

  • Update capabilities.conf.
  • Use sys_break in linux compat.
  • Handle freebsd32 and ibcs.
  • Rebase on top of new return.

Change seems sensible to me.

sys/compat/linux/linux_misc.c
245 ↗(On Diff #43454)

Change for a later commit -- on IRC @kib pointed this out to me in a different context: we shouldn't be calling the syscall entry point like this, but rather split sys_break into sys_break and kern_break, and call the latter from sys_break and linux_brk.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2018, 9:27 PM
This revision was automatically updated to reflect the committed changes.