The break() system call was renamed (several times) starting in v3 AT&T
UNIX when C was invented and break was a language keyword. The last
vestage of a need for it to be called something else (eg obreak) was removed
in r225617 which consistantly prefixed all syscall implementations.
Details
Details
- Reviewers
kib jhb emaste - Commits
- rS335177: Name the implementation of brk and sbrk sys_break().
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Don't you miss compat32 ?
sys/vm/vm_unix.c | ||
---|---|---|
198 ↗ | (On Diff #43221) | Remove this printf, it is spam. |
Comment Actions
Change seems sensible to me.
sys/compat/linux/linux_misc.c | ||
---|---|---|
245 ↗ | (On Diff #43454) | Change for a later commit -- on IRC @kib pointed this out to me in a different context: we shouldn't be calling the syscall entry point like this, but rather split sys_break into sys_break and kern_break, and call the latter from sys_break and linux_brk. |