Page MenuHomeFreeBSD
Differential D15533

Fix coverity CID: 1391235, 1193654 and 1193651 (Unchecked return value)
ClosedPublic
Actions

Authored by araujo on May 23 2018, 9:16 AM.

Details

Reviewers
rgrimes
grehan
neel
tychon
anish
jhb
avg
Commits
rS334084: pthread_rwlock_unlock(3) returns 0 if successful, otherwise an error number
Summary

pthread_rwlock_unlock(3) returns 0 if successful, otherwise an error number
will be returned to indicate the error, so I'm applying an assert(3) to do
a sanity check of the return value.

Test Plan

Rebuild bhyve with this patch:

  1. Test FreeBSD HEAD as a guest.
  2. Test FreeBSD HEAD as a guest with "wire guest memory -S".

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

araujo created this revision.May 23 2018, 9:16 AM
grehan accepted this revision.May 23 2018, 9:25 AM
This revision is now accepted and ready to land.May 23 2018, 9:25 AM
Closed by commit rS334084: pthread_rwlock_unlock(3) returns 0 if successful, otherwise an error number (authored by araujo). · Explain WhyMay 23 2018, 9:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhead/usr.sbin/bhyve/mem.c (32 lines)

Diff 42876

View Options

head/usr.sbin/bhyve/mem.c

Loading...