Differential D15512

Included VSX registers in powerpc core dumps
ClosedPublic
Actions

Authored by lffpires_ruabrasil.org on May 21 2018, 6:20 PM.

Tags

Referenced Files

	F139429368: D15512.id.diff
	Fri, Dec 12, 12:03 AM

	F139394242: D15512.diff
	Thu, Dec 11, 3:37 PM

	Unknown Object (File)
	Sun, Dec 7, 8:57 PM

	Unknown Object (File)
	Fri, Nov 28, 2:25 AM

	Unknown Object (File)
	Tue, Nov 25, 10:45 PM

	Unknown Object (File)
	Fri, Nov 21, 10:38 AM

	Unknown Object (File)
	Thu, Nov 20, 4:41 PM

	Unknown Object (File)
	Thu, Nov 20, 4:40 PM

Subscribers

breno.leitao_gmail.com

leonardo.bianconi_eldorado.org.br

Details

Reviewers

jhibbits
nwhitehorn

Commits

rS334538: Included VSX registers in powerpc core dumps

Summary

Included VSX registers in powerpc core dumps (both kernel and gcore)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16739
Build 16628: arc lint + arc unit

Event Timeline

lffpires_ruabrasil.org created this revision.May 21 2018, 6:20 PM

Herald added a subscriber: jhibbits. · View Herald TranscriptMay 21 2018, 6:20 PM

Harbormaster completed remote builds in B16739: Diff 42805.May 21 2018, 6:20 PM

lffpires_ruabrasil.org added reviewers: jhibbits, nwhitehorn.May 21 2018, 6:23 PM

lffpires_ruabrasil.org edited subscribers, added: breno.leitao_gmail.com; removed: jhibbits.

Herald added a subscriber: leonardo.bianconi_eldorado.org.br. · View Herald TranscriptMay 21 2018, 6:23 PM

lffpires_ruabrasil.org added a project: PowerPC.May 21 2018, 7:25 PM

jhibbits added inline comments.May 26 2018, 1:57 AM

sys/powerpc/powerpc/elf64_machdep.c
249	Is this change needed? 'len' is already 0 at this point. I guess if we were to add something before VMX this would be necessary.

lffpires_ruabrasil.org added inline comments.May 28 2018, 1:05 PM

sys/powerpc/powerpc/elf64_machdep.c
249	It's not needed. I did it because I thought making all the 'if' blocks (VMX / VSX) here the same would make the code less susceptible to errors. When adding new ones, people could just copy from either of them, change their order, and so on, without breaking anything. I guess it's the same thinking that led to using "len +=" instead of "len =" at the beginning of the line.

jhibbits accepted this revision.May 31 2018, 4:48 AM

This revision is now accepted and ready to land.May 31 2018, 4:48 AM

Closed by commit rS334538: Included VSX registers in powerpc core dumps (authored by jhibbits). · Explain WhyJun 2 2018, 8:29 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 2 2018, 8:29 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

powerpc/

elf32_machdep.c

28 lines

elf64_machdep.c

28 lines

sys/

1 line

usr.bin/

gcore/

26 lines

Diff 42805

sys/powerpc/powerpc/elf32_machdep.c

Loading...

sys/powerpc/powerpc/elf64_machdep.c

Loading...

sys/sys/elf_common.h

Loading...

usr.bin/gcore/elfcore.c

Loading...