Page MenuHomeFreeBSD

Included VSX registers in powerpc core dumps
ClosedPublic

Authored by lffpires_ruabrasil.org on May 21 2018, 6:20 PM.
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:51 AM
Unknown Object (File)
Dec 19 2023, 3:57 PM
Unknown Object (File)
Dec 10 2023, 7:43 PM
Unknown Object (File)
Nov 9 2023, 8:30 AM
Unknown Object (File)
Nov 5 2023, 10:57 AM
Unknown Object (File)
Nov 5 2023, 6:52 AM
Unknown Object (File)
Nov 4 2023, 4:18 AM
Unknown Object (File)
Oct 17 2023, 10:42 AM

Details

Summary

Included VSX registers in powerpc core dumps (both kernel and gcore)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16739
Build 16628: arc lint + arc unit

Event Timeline

sys/powerpc/powerpc/elf64_machdep.c
249

Is this change needed? 'len' is already 0 at this point. I guess if we were to add something before VMX this would be necessary.

sys/powerpc/powerpc/elf64_machdep.c
249

It's not needed. I did it because I thought making all the 'if' blocks (VMX / VSX) here the same would make the code less susceptible to errors. When adding new ones, people could just copy from either of them, change their order, and so on, without breaking anything.

I guess it's the same thinking that led to using "len +=" instead of "len =" at the beginning of the line.

This revision is now accepted and ready to land.May 31 2018, 4:48 AM
This revision was automatically updated to reflect the committed changes.