Page MenuHomeFreeBSD

breno.leitao_gmail.com (Breno Leitao)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2018, 4:52 PM (93 w, 10 h)

Recent Activity

Aug 27 2018

breno.leitao_gmail.com added a reviewer for D16889: powerpc64: Add initial support for HTM: jhibbits.
Aug 27 2018, 11:16 PM

Aug 24 2018

breno.leitao_gmail.com added inline comments to D15243: Powerpc64: Enable Hardware Transactional Memory.
Aug 24 2018, 9:42 PM
breno.leitao_gmail.com created D16889: powerpc64: Add initial support for HTM.
Aug 24 2018, 9:37 PM

Aug 22 2018

breno.leitao_gmail.com updated the diff for D15243: Powerpc64: Enable Hardware Transactional Memory.

Minor fixes

Aug 22 2018, 6:32 PM
breno.leitao_gmail.com added a comment to D15243: Powerpc64: Enable Hardware Transactional Memory.

This patchset has one caveat at this time that will be fixed soon. If we go into kernel space during the transaction, and the process is rescheduled to another cpu, the transaction state will be on the original CPU, and the new CPU will not have the same CPU state, caused an undefined behaviour.

Aug 22 2018, 5:21 PM
breno.leitao_gmail.com updated the diff for D15243: Powerpc64: Enable Hardware Transactional Memory.

Adding additional testsuite for the code.

Aug 22 2018, 5:11 PM

Aug 7 2018

breno.leitao_gmail.com added a reviewer for D16617: powerpc64/powernv: re-read RTC after polling: wma.
Aug 7 2018, 10:40 PM
breno.leitao_gmail.com added reviewers for D16617: powerpc64/powernv: re-read RTC after polling: nwhitehorn, jhibbits.
Aug 7 2018, 10:37 PM
breno.leitao_gmail.com created D16617: powerpc64/powernv: re-read RTC after polling.
Aug 7 2018, 10:36 PM

Jul 27 2018

breno.leitao_gmail.com created D16474: tools/htm_torture: Tool to stress HTM sub system ..
Jul 27 2018, 6:57 PM
breno.leitao_gmail.com updated the diff for D15243: Powerpc64: Enable Hardware Transactional Memory.

Add aditional tests. Mainly two things:

  • Instead of testing for transactional states, look for active (Transactional + Suspended)
  • Avoid signal handling inside a transaction, since the code will be rolled back.
Jul 27 2018, 5:57 PM

Jun 19 2018

breno.leitao_gmail.com updated the diff for D15705: ofw: Load initrd file.

Adding Justin's suggestions and removing an unused variable.

Jun 19 2018, 2:37 PM

Jun 15 2018

breno.leitao_gmail.com accepted D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.
Jun 15 2018, 6:41 PM

Jun 12 2018

breno.leitao_gmail.com updated the diff for D15763: powerpc64: Avoid type promotion.

Fixing silly error.

Jun 12 2018, 1:00 PM

Jun 11 2018

breno.leitao_gmail.com updated the diff for D15763: powerpc64: Avoid type promotion.

Adjusting to follow jhibbits' suggestion.

Jun 11 2018, 9:41 PM
breno.leitao_gmail.com added reviewers for D15763: powerpc64: Avoid type promotion: wma, jhibbits.
Jun 11 2018, 7:55 PM
breno.leitao_gmail.com updated the diff for D15763: powerpc64: Avoid type promotion.

Better approach forcing promotion.

Jun 11 2018, 7:53 PM
breno.leitao_gmail.com created D15763: powerpc64: Avoid type promotion.
Jun 11 2018, 7:27 PM

Jun 8 2018

breno.leitao_gmail.com updated the diff for D15705: ofw: Load initrd file.

Change OF_getencprop() to OF_hasprop() on probe() function.

Jun 8 2018, 3:03 PM
breno.leitao_gmail.com added reviewers for D15705: ofw: Load initrd file: jhibbits, nwhitehorn.
Jun 8 2018, 2:30 PM
breno.leitao_gmail.com created D15705: ofw: Load initrd file.
Jun 8 2018, 2:27 PM

Jun 7 2018

breno.leitao_gmail.com accepted D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 7 2018, 8:57 PM · PowerPC

Jun 6 2018

breno.leitao_gmail.com updated the diff for D15625: md: use prestaged mfs_root.

Removing the volatile qualifier for mfs_root and mfs_root_size.

Jun 6 2018, 7:52 PM
breno.leitao_gmail.com added inline comments to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 6 2018, 6:40 PM · PowerPC

Jun 5 2018

breno.leitao_gmail.com accepted D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Jun 5 2018, 9:09 PM · PowerPC
breno.leitao_gmail.com added a comment to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.

I tested it on my POWER9 and it continues to boot. This change seems to make sense, and fixes 32-bits initrd addresses, but I am not sure how it broke Justin's P9, and if it is going to fix.

Jun 5 2018, 9:09 PM · PowerPC

Jun 1 2018

breno.leitao_gmail.com added a reviewer for D15625: md: use prestaged mfs_root: kib.
Jun 1 2018, 3:58 PM

May 30 2018

breno.leitao_gmail.com added reviewers for D15625: md: use prestaged mfs_root: nwhitehorn, jhibbits.
May 30 2018, 7:55 PM
breno.leitao_gmail.com created D15625: md: use prestaged mfs_root.
May 30 2018, 7:53 PM

May 29 2018

breno.leitao_gmail.com added reviewers for D15610: powerpc64: Avoid overwriting initrd area: jhibbits, nwhitehorn.
May 29 2018, 9:18 PM
breno.leitao_gmail.com created D15610: powerpc64: Avoid overwriting initrd area.
May 29 2018, 9:17 PM

May 28 2018

breno.leitao_gmail.com accepted D15566: Make opal_pci driver work with POWER9.
May 28 2018, 6:38 PM
breno.leitao_gmail.com accepted D15461: Restrict PCIe maxslots to 0, instead of PCI_SLOTMAX.

I tested this change on my POWER8 pseries system and it worked fine.

May 28 2018, 1:48 PM

May 21 2018

breno.leitao_gmail.com accepted D15362: Basic OPAL sensor support for POWER9 platforms.

I reviewed this code and it seems OK to be integrated.

May 21 2018, 6:36 PM

May 18 2018

breno.leitao_gmail.com added a comment to D15482: powerpc64: Ignore NVlink memory regions.
  1. Is there a document describing this that we can reference?
May 18 2018, 6:12 PM
breno.leitao_gmail.com added reviewers for D15482: powerpc64: Ignore NVlink memory regions: nwhitehorn, jhibbits.
May 18 2018, 5:45 PM
breno.leitao_gmail.com updated the diff for D15482: powerpc64: Ignore NVlink memory regions.

Fixing spacing

May 18 2018, 5:44 PM
breno.leitao_gmail.com created D15482: powerpc64: Ignore NVlink memory regions.
May 18 2018, 5:41 PM

May 16 2018

breno.leitao_gmail.com added inline comments to D15243: Powerpc64: Enable Hardware Transactional Memory.
May 16 2018, 2:57 PM
breno.leitao_gmail.com updated the diff for D15243: Powerpc64: Enable Hardware Transactional Memory.

Changes according to the Justin's review:

May 16 2018, 2:56 PM

May 14 2018

breno.leitao_gmail.com added reviewers for D15432: powerpc64: Add OPAL definitions: jhibbits, nwhitehorn.
May 14 2018, 7:01 PM
breno.leitao_gmail.com created D15432: powerpc64: Add OPAL definitions.
May 14 2018, 6:54 PM

May 11 2018

breno.leitao_gmail.com added a comment to D15368: strcpy optimization for PowerPC64.

Hi Leonardo,

May 11 2018, 1:11 PM · PowerPC

May 9 2018

breno.leitao_gmail.com added a comment to D15372: Fix PPC symbol resolution.

Thanks Leandro. This closes bug#227093

May 9 2018, 9:39 PM
breno.leitao_gmail.com added inline comments to D15362: Basic OPAL sensor support for POWER9 platforms.
May 9 2018, 1:56 PM
breno.leitao_gmail.com added a comment to D15362: Basic OPAL sensor support for POWER9 platforms.

Hi Justin.

May 9 2018, 1:29 PM

May 7 2018

breno.leitao_gmail.com added a comment to D15331: Enable XIVE XICS emulation mode for POWER9 interrupt controller.

Hi Justin,

May 7 2018, 1:51 PM

May 4 2018

breno.leitao_gmail.com updated the diff for D15288: powerpc64: Add extra SPRs on fatal traps.

Removing extra line.

May 4 2018, 1:13 AM
breno.leitao_gmail.com created D15288: powerpc64: Add extra SPRs on fatal traps.
May 4 2018, 1:09 AM

Apr 30 2018

breno.leitao_gmail.com added reviewers for D15243: Powerpc64: Enable Hardware Transactional Memory: nwhitehorn, jhibbits.
Apr 30 2018, 6:45 PM
breno.leitao_gmail.com created D15243: Powerpc64: Enable Hardware Transactional Memory.
Apr 30 2018, 6:39 PM

Apr 23 2018

breno.leitao_gmail.com added reviewers for D14484: powerpc64: Add a trap stack area: nwhitehorn, jhibbits.
Apr 23 2018, 5:15 PM · PowerPC

Apr 18 2018

breno.leitao_gmail.com added reviewers for D15128: powerpc64: Set n_slbs = 32 for POWER9: nwhitehorn, jhibbits.
Apr 18 2018, 8:36 PM
breno.leitao_gmail.com created D15128: powerpc64: Set n_slbs = 32 for POWER9.
Apr 18 2018, 8:20 PM
breno.leitao_gmail.com added inline comments to D15118: memcpy optimization for powerpc64.
Apr 18 2018, 1:51 PM · PowerPC
breno.leitao_gmail.com added inline comments to D15118: memcpy optimization for powerpc64.
Apr 18 2018, 1:26 PM · PowerPC

Apr 17 2018

breno.leitao_gmail.com updated the diff for D15081: powerpc64: Add DSCR support.

Use SPR_DSCR macro instead of SPR number (0x11)

Apr 17 2018, 8:33 PM
breno.leitao_gmail.com updated the diff for D15081: powerpc64: Add DSCR support.

Removing mfdscr() inline function and replacing by mfspr(SPR_DSCR).

Apr 17 2018, 1:34 PM

Apr 16 2018

breno.leitao_gmail.com updated the summary of D15081: powerpc64: Add DSCR support.
Apr 16 2018, 1:04 AM
breno.leitao_gmail.com created D15081: powerpc64: Add DSCR support.
Apr 16 2018, 1:01 AM

Apr 6 2018

breno.leitao_gmail.com updated the diff for D14955: powerpc/ofw: Fix malloc inside lock.

Updating the patch with mjg's suggestions. Thanks for the review.

Apr 6 2018, 5:51 PM

Apr 5 2018

breno.leitao_gmail.com updated the diff for D14955: powerpc/ofw: Fix malloc inside lock.

Updating the patch to remove the mem alloc from outside the lock section.

Apr 5 2018, 9:00 PM

Apr 3 2018

breno.leitao_gmail.com added reviewers for D14955: powerpc/ofw: Fix malloc inside lock: jhibbits, nwhitehorn.
Apr 3 2018, 8:36 PM
breno.leitao_gmail.com created D14955: powerpc/ofw: Fix malloc inside lock.
Apr 3 2018, 8:09 PM

Mar 7 2018

breno.leitao_gmail.com accepted D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

This is working fine on pseries also. The problem I reported above was found to not be related to this revision.

Mar 7 2018, 4:28 PM · PowerPC

Mar 6 2018

breno.leitao_gmail.com created D14600: powerpc64: Print current MSR on printtrap().
Mar 6 2018, 8:45 PM
breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

This is fascinating. Could you verify that this happens without this patch (I assume it is unrelated?) and give some more details on your setup that gave this error. I would like to try to get to the bottom of it.

Mar 6 2018, 5:55 PM · PowerPC
breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

This is the regular boot (without usefdt=1).

Mar 6 2018, 4:23 PM · PowerPC
breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

Hi Nathan,
With the current patch, I was able to test it properly on my pseries VM, but I didn't use usefdt=1, mainly because I didn't know where to use it. Should I need to recompile the loader to use it, or, is it a parameter somewhere?

And it was working fine?

Mar 6 2018, 4:21 PM · PowerPC
breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

Hi Nathan,

Mar 6 2018, 3:25 PM · PowerPC

Mar 5 2018

breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

Looking at DSISR (0x40000000), it seems that the only bit enable represents the following thing:

Mar 5 2018, 3:00 PM · PowerPC
breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

I tried you most recent patchset and it is still not working on pseries.

Mar 5 2018, 2:50 PM · PowerPC

Mar 4 2018

breno.leitao_gmail.com created D14583: powerpc64: Avoid calling isync twice.
Mar 4 2018, 9:41 PM

Mar 3 2018

breno.leitao_gmail.com updated the diff for D14566: Powerpc64: Add the facility unavailable trap subsystem.

Patchset v2. Changes as requested by Justin (Thanks!):

Mar 3 2018, 7:28 PM
breno.leitao_gmail.com added a comment to D14566: Powerpc64: Add the facility unavailable trap subsystem.

hi Justin, thanks for the review. I will work on a v2 patchset.

Mar 3 2018, 7:01 PM

Mar 2 2018

breno.leitao_gmail.com created D14566: Powerpc64: Add the facility unavailable trap subsystem.
Mar 2 2018, 5:50 PM

Feb 26 2018

breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

If the above analyzes is correct, It seems that a function ends up with a conditional branch, so, if the condition is not reached, then it moved to the function epilogue, which is 0x0.

Feb 26 2018, 8:51 PM · PowerPC
breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.

Once my machine stops, it just shows:

Feb 26 2018, 8:26 PM · PowerPC
breno.leitao_gmail.com added a comment to D14499: Move powerpc64 direct map from 0 to 0xc000000000000000.
Feb 26 2018, 5:01 PM · PowerPC
breno.leitao_gmail.com updated the diff for D14484: powerpc64: Add a trap stack area.
Feb 26 2018, 4:18 PM · PowerPC
breno.leitao_gmail.com updated the diff for D14487: powerpc64: Remove unused variables avoid gcc warnings.

Resubmitting a code that treats the errors other than ignoring them,.

Feb 26 2018, 2:44 PM
breno.leitao_gmail.com updated the diff for D14484: powerpc64: Add a trap stack area.
Feb 26 2018, 2:39 PM · PowerPC

Feb 23 2018

breno.leitao_gmail.com created D14487: powerpc64: Remove unused variables avoid gcc warnings.
Feb 23 2018, 6:52 PM
breno.leitao_gmail.com created D14484: powerpc64: Add a trap stack area.
Feb 23 2018, 5:07 PM · PowerPC

Feb 9 2018

breno.leitao_gmail.com retitled D14281: powerpc64/pseries: Define new hcalls from powerpc66/pseries: Define new hcalls to powerpc64/pseries: Define new hcalls.
Feb 9 2018, 8:45 PM
breno.leitao_gmail.com created D14281: powerpc64/pseries: Define new hcalls.
Feb 9 2018, 4:16 PM

Feb 8 2018

breno.leitao_gmail.com updated the diff for D14204: PC64: Get the timestap from the proper OF field.
Feb 8 2018, 6:40 PM · PowerPC
breno.leitao_gmail.com updated the diff for D14204: PC64: Get the timestap from the proper OF field.
Feb 8 2018, 5:43 PM · PowerPC
breno.leitao_gmail.com updated the diff for D14204: PC64: Get the timestap from the proper OF field.
Feb 8 2018, 5:25 PM · PowerPC
breno.leitao_gmail.com added a comment to D14204: PC64: Get the timestap from the proper OF field.

Let me attach a new fix as proposed by Justin

Feb 8 2018, 5:25 PM · PowerPC

Feb 5 2018

breno.leitao_gmail.com created D14204: PC64: Get the timestap from the proper OF field.
Feb 5 2018, 5:23 PM · PowerPC