Minor fixes

This patchset has one caveat at this time that will be fixed soon. If we go into kernel space during the transaction, and the process is rescheduled to another cpu, the transaction state will be on the original CPU, and the new CPU will not have the same CPU state, caused an undefined behaviour.

Adding additional testsuite for the code.

Add aditional tests. Mainly two things:

• Instead of testing for transactional states, look for active (Transactional + Suspended)
• Avoid signal handling inside a transaction, since the code will be rolled back.

Adding Justin's suggestions and removing an unused variable.

Fixing silly error.

Adjusting to follow jhibbits' suggestion.

Better approach forcing promotion.

Change OF_getencprop() to OF_hasprop() on probe() function.

Removing the volatile qualifier for mfs_root and mfs_root_size.

I tested it on my POWER9 and it continues to boot. This change seems to make sense, and fixes 32-bits initrd addresses, but I am not sure how it broke Justin's P9, and if it is going to fix.

I tested this change on my POWER8 pseries system and it worked fine.

I reviewed this code and it seems OK to be integrated.

1. Is there a document describing this that we can reference?

Fixing spacing

Changes according to the Justin's review:

Hi Leonardo,

Thanks Leandro. This closes bug#227093

Hi Justin.

Hi Justin,

Removing extra line.

Use SPR_DSCR macro instead of SPR number (0x11)

Removing mfdscr() inline function and replacing by mfspr(SPR_DSCR).

Updating the patch with mjg's suggestions. Thanks for the review.

Updating the patch to remove the mem alloc from outside the lock section.

This is working fine on pseries also. The problem I reported above was found to not be related to this revision.

This is fascinating. Could you verify that this happens without this patch (I assume it is unrelated?) and give some more details on your setup that gave this error. I would like to try to get to the bottom of it.

This is the regular boot (without usefdt=1).

In D14499#306478, @nwhitehorn wrote:

In D14499#306477, @breno.leitao_gmail.com wrote:

Hi Nathan,

With the current patch, I was able to test it properly on my pseries VM, but I didn't use usefdt=1, mainly because I didn't know where to use it. Should I need to recompile the loader to use it, or, is it a parameter somewhere?

And it was working fine?

Hi Nathan,

Looking at DSISR (0x40000000), it seems that the only bit enable represents the following thing:

I tried you most recent patchset and it is still not working on pseries.

Patchset v2. Changes as requested by Justin (Thanks!):

hi Justin, thanks for the review. I will work on a v2 patchset.

If the above analyzes is correct, It seems that a function ends up with a conditional branch, so, if the condition is not reached, then it moved to the function epilogue, which is 0x0.

Once my machine stops, it just shows:

Resubmitting a code that treats the errors other than ignoring them,.

Let me attach a new fix as proposed by Justin