Page MenuHomeFreeBSD

Included VSX registers in powerpc core dumps
ClosedPublic

Authored by lffpires_ruabrasil.org on May 21 2018, 6:20 PM.

Details

Summary

Included VSX registers in powerpc core dumps (both kernel and gcore)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/powerpc/powerpc/elf64_machdep.c
249 ↗(On Diff #42805)

Is this change needed? 'len' is already 0 at this point. I guess if we were to add something before VMX this would be necessary.

sys/powerpc/powerpc/elf64_machdep.c
249 ↗(On Diff #42805)

It's not needed. I did it because I thought making all the 'if' blocks (VMX / VSX) here the same would make the code less susceptible to errors. When adding new ones, people could just copy from either of them, change their order, and so on, without breaking anything.

I guess it's the same thinking that led to using "len +=" instead of "len =" at the beginning of the line.

This revision is now accepted and ready to land.May 31 2018, 4:48 AM
This revision was automatically updated to reflect the committed changes.