Use strsep() to parse init_path in start_init().
ClosedPublic
Actions

Authored by brooks on May 17 2018, 8:13 PM.

Details

Reviewers

imp
cperciva
ed
jhb

Commits

rS333773: Use strsep() to parse init_path in start_init().

Summary

This simplifies the use of the path variable by making it NUL
terminated. This is a prerequisite for further cleanups.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.May 17 2018, 8:13 PM

Harbormaster completed remote builds in B16651: Diff 42674.May 17 2018, 8:13 PM

Developed on CheriBSD (mips64), testing in an amd64 VM including verifying that single user mode works.

Once this and D15468 are in, I have another change to remove the temporary mapping in the stack region and just construct a struct image_args here for kern_execve().

Despite a couple grumbles, this looks good to my eye.

sys/kern/init_main.c
734 ↗	(On Diff #42674)	We don't have strdup?
771 ↗	(On Diff #42674)	are there any alignment requirements for ucp?
805 ↗	(On Diff #42674)	Kinda lame to free something just before panic :)

This revision is now accepted and ready to land.May 17 2018, 9:45 PM

brooks added inline comments.May 17 2018, 10:33 PM

sys/kern/init_main.c
734 ↗	(On Diff #42674)	Hmm, I was sure we didn't, but we do. I'll switch.
771 ↗	(On Diff #42674)	Nope, it's just a bunch of strings in a row.
805 ↗	(On Diff #42674)	I debated this, but concluded that leak checkers would probably be happier without a path with no free.