Page MenuHomeFreeBSD

Add 32-bit compat for ioctls that take struct ifgroupreq.
ClosedPublic

Authored by brooks on Apr 4 2018, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 22, 3:02 PM
Unknown Object (File)
Wed, May 14, 5:53 PM
Unknown Object (File)
Sat, May 3, 10:13 PM
Unknown Object (File)
Apr 28 2025, 12:28 PM
Unknown Object (File)
Apr 27 2025, 9:21 PM
Unknown Object (File)
Apr 14 2025, 7:41 AM
Unknown Object (File)
Apr 14 2025, 5:18 AM
Unknown Object (File)
Apr 14 2025, 2:01 AM
Subscribers

Details

Summary

Use an accessor to access ifgr_group and ifgr_groups.

Use an macro CASE_IOC_IFGROUPREQ(cmd) in place of case statements such
as "case SIOCAIFGROUP:". This avoids poluting the switch statements
with large numbers of #ifdefs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/net/if.c
2856 ↗(On Diff #41099)

May be consider fixing style by moving ifgr declaration at top, and removing useless {}.

This revision is now accepted and ready to land.Apr 4 2018, 5:44 PM
  • Avoid unneeded ifgr temporary and be consistant about casting from data.
This revision now requires review to proceed.Apr 4 2018, 9:46 PM
This revision is now accepted and ready to land.Apr 4 2018, 9:55 PM
This revision was automatically updated to reflect the committed changes.