Use LIST_FOREACH_SAFE in sleepq_chains_remove_matching()
ClosedPublic
Actions

Authored by markj on Mar 25 2018, 6:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 4, 6:41 AM

	Unknown Object (File)
	Fri, Jul 3, 12:30 PM

	Unknown Object (File)
	Thu, Jul 2, 5:02 PM

	Unknown Object (File)
	Wed, Jul 1, 8:59 PM

	Unknown Object (File)
	Tue, Jun 30, 8:52 PM

	Unknown Object (File)
	Wed, Jun 24, 9:47 AM

	Unknown Object (File)
	May 20 2026, 11:56 AM

	Unknown Object (File)
	May 20 2026, 11:56 AM

View All Files

Subscribers

imp

Details

Reviewers

vangyzen
kib
jhb

Commits

rS331536: Use LIST_FOREACH_SAFE in sleepq_chains_remove_matching().

Summary

We may remove a sleepqueue from the hashtable in sleepq_resume_thread().

Test Plan

I hit panics in Isilon OneFS after merging r315280, and we have QUEUE_MACRO_DEBUG configured.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 25 2018, 6:44 PM

Harbormaster completed remote builds in B15797: Diff 40732.Mar 25 2018, 6:44 PM

markj edited the test plan for this revision. (Show Details)Mar 25 2018, 6:46 PM

markj added reviewers: vangyzen, kib, jhb.

kib accepted this revision.Mar 25 2018, 7:43 PM

This revision is now accepted and ready to land.Mar 25 2018, 7:43 PM

Closed by commit rS331536: Use LIST_FOREACH_SAFE in sleepq_chains_remove_matching(). (authored by markj). · Explain WhyMar 25 2018, 8:12 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2018, 8:12 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

subr_sleepqueue.c

4 lines

Diff 40734

View Options

head/sys/kern/subr_sleepqueue.c

Use LIST_FOREACH_SAFE in sleepq_chains_remove_matching()ClosedPublicActions