Fix access to ifru_buffer on freebsd32.
ClosedPublic
Actions

Authored by brooks on Mar 25 2018, 5:36 PM.

Details

Reviewers

kib
emaste
jhb

Commits

rS332281: MFC r331641, r331644, r332158
rS331641: Fix access to ifru_buffer on freebsd32.

Summary

Make all accesses to ifru_buffer go via access functions which take the
process ABI into account and use an appropriate union to access members
in the correct place in struct ifreq.

Obtained from: CheriBSD
Sponsored by: DARPA, AFRL

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 25 2018, 5:36 PM

Herald added a subscriber: ae. · View Herald TranscriptMar 25 2018, 5:36 PM

Harbormaster completed remote builds in B15795: Diff 40730.Mar 25 2018, 5:36 PM

brooks retitled this revision from Fix access to ifru_buffer on 32-bit systems. to Fix access to ifru_buffer on freebsd32..Mar 25 2018, 5:38 PM

kib added inline comments.Mar 25 2018, 5:50 PM

sys/net/if.c
2358 ↗	(On Diff #40730)	'else' is not needed there and in all subsequent #ifdefs with returns. Then you can un-indent the unconditionally-compiled line.
2373 ↗	(On Diff #40730)	Then why the argument is needed ?

Remove unneeded else in "get" cases.
Rename ifr_buffer_set_buffer to ifr_buffer_set_buffer_null and eliminate

Harbormaster completed remote builds in B15818: Diff 40778.Mar 26 2018, 11:49 PM

kib accepted this revision.Mar 27 2018, 8:09 AM

kib added inline comments.

sys/net/if.c
2346 ↗	(On Diff #40778)	Does it make sense to provide a stand-alone definition of this union and use it in all functions instead of repeating #ifdefs ?