Page MenuHomeFreeBSD

Add full dual license headers to the VMCI driver
AbandonedPublic

Authored by mp on Mar 25 2018, 5:17 PM.

Details

Reviewers
imp
rgrimes
bcr
vdasahar_gmail.com
Group Reviewers
manpages
Summary

Per review by rgrimes, SPDX headers are considered insufficient for
licensing source files in the src tree. This change expands the license
text in each file per the intent and alignment by VMware.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15794
Build 15805: arc lint + arc unit

Event Timeline

mp created this revision.Mar 25 2018, 5:17 PM
imp accepted this revision.Mar 25 2018, 5:45 PM

rgrimes doesn't know what he's talking about. This change is completely unnecessary. What's there now is legally sufficient.

This revision is now accepted and ready to land.Mar 25 2018, 5:45 PM
imp requested changes to this revision.Mar 25 2018, 5:46 PM

I should have clicked X not Check.

This revision now requires changes to proceed.Mar 25 2018, 5:46 PM
mp abandoned this revision.Mar 25 2018, 5:49 PM

Per imp, abandon this review as existing license is sufficient.

emaste added a subscriber: emaste.Mar 26 2018, 6:32 PM

The change to OR should go in independent of the resolution on the full text question.