Page MenuHomeFreeBSD

vdasahar_gmail.com (Vishnu Dasa)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2018, 8:41 PM (88 w, 3 d)

Recent Activity

Apr 6 2018

vdasahar_gmail.com accepted D14979: Update VMCI license.

Thanks for fixing this Mark! Looks good to me.

Apr 6 2018, 4:31 AM

Mar 30 2018

vdasahar_gmail.com added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Coverity found a number of issues with this commit. It is possible they are false positives:

  • CID 1056844: API usage errors (SWAPPED_ARGUMENTS)

/sys/dev/vmware/vmci/vmci_qpair.c: 400 in vmci_qpair_consume_free_space()
394
395 if (!qpair)
396 return (VMCI_ERROR_INVALID_ARGS);
397
398 vmci_qpair_get_queue_headers(qpair, &produce_q_header,
399 &consume_q_header);

CID 1056844:  API usage errors  (SWAPPED_ARGUMENTS)
The positions of arguments in the call to "vmci_queue_header_free_space" do not match the ordering of the parameters:
  • "consume_q_header" is passed to "produce_q_header"
  • "produce_q_header" is passed to "consume_q_header"

400 result = vmci_queue_header_free_space(consume_q_header, produce_q_header,
401 qpair->consume_q_size);
402
403 return (result);
404 }
405

  • CID 1056845: API usage errors (SWAPPED_ARGUMENTS)

/sys/dev/vmware/vmci/vmci_qpair.c: 320 in vmci_qpair_get_consume_indexes()

  • CID 1056846: API usage errors (SWAPPED_ARGUMENTS)

/sys/dev/vmware/vmci/vmci_qpair.c: 438 in vmci_qpair_produce_buf_ready()

Mar 30 2018, 6:09 AM

Mar 24 2018

vdasahar_gmail.com added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Thank you Mark!

Mar 24 2018, 2:31 AM

Mar 22 2018

vdasahar_gmail.com added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

@imp Thank you Warner! I have made the change that you suggested.

Mar 22 2018, 3:54 AM
vdasahar_gmail.com updated the diff for D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Change path in Makefile

Mar 22 2018, 3:50 AM

Mar 20 2018

vdasahar_gmail.com added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Ping. Gentle reminder.

Mar 20 2018, 2:11 AM

Feb 10 2018

vdasahar_gmail.com added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.
In D14289#299838, @bcr wrote:

Looks good now. OK from the manpages part of the module.

Feb 10 2018, 6:15 PM
vdasahar_gmail.com updated the diff for D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Add socket(2) to SEE ALSO section in man page.

Feb 10 2018, 3:34 PM
vdasahar_gmail.com updated the diff for D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Thank you @bcr! I've added AUTHORS, HISTORY and SEE ALSO section to the man
page.

Feb 10 2018, 3:20 PM
vdasahar_gmail.com updated the diff for D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Fixed formatting errors in man page. Used igor to proofread the document after
the changes.

Feb 10 2018, 1:19 PM
vdasahar_gmail.com added a comment to D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.
In D14289#299768, @bcr wrote:

A few comments on the man page. You can use textproc/igor to check the man page for various common errors.
Thank you very much for working on this kernel module!

Feb 10 2018, 1:18 PM
vdasahar_gmail.com added reviewers for D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module: imp, mp.
Feb 10 2018, 12:34 AM
vdasahar_gmail.com updated the diff for D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Remove unnecessary newline with SUBDIR+= in the upper level Makefile at vmxnet3.
Use more SRCS+= to keep the list to below 80 characters.

Feb 10 2018, 12:11 AM

Feb 9 2018

vdasahar_gmail.com updated the diff for D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.

Fix the file permissions to be 644

Feb 9 2018, 10:33 PM
vdasahar_gmail.com created D14289: VMware Virtual Machine Communication Interface (VMCI) kernel module.
Feb 9 2018, 10:27 PM