Page MenuHomeFreeBSD

Extend kde.mk with plist handling for documentation
ClosedPublic

Authored by tcberner on Mar 24 2018, 10:45 AM.

Details

Summary

Extend kde.mk to automatically add documention in ${PREFIX}/share/doc/HTML/* to the plist

@mat, is portmgr fine with doing stuff like this?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner created this revision.Mar 24 2018, 10:45 AM
tcberner updated this revision to Diff 40680.Mar 24 2018, 10:58 AM

Remove SHLIB changes (committed separately)

Which problem does this solve?

Which problem does this solve?

Generally every update of the applications changes a few files sv/bar goes missing de/foo comes back -- which makes every update of the ports a bit tedious (as there are around 200 ports)

To clarify, this will only be used for ports that set CATEGORIES=kde-application

adridg added a subscriber: adridg.Mar 24 2018, 12:10 PM

While I prefer explicit pkg-plists, this is (only) about the HTML documentation, and it saves considerable time in updating ports (releases are every three months).

tcberner abandoned this revision.Mar 24 2018, 12:19 PM

Ok, it's probably better to have explicit plists.

tcberner reclaimed this revision.Mar 24 2018, 12:41 PM

... let's discuss that some more :D

Can this be committed without the changes to filelight (kf5) and kdelibs (kde4)? Wouldn't kdelibs4 fall outside of the KDE Applications group, and so still need the docs listed?

tcberner added a comment.EditedMar 24 2018, 5:16 PM

Can this be committed without the changes to filelight (kf5) and kdelibs (kde4)? Wouldn't kdelibs4 fall outside of the KDE Applications group, and so still need the docs listed?

Easily (for kdelibs), by matching _KDE_VERSION=5 .

kdelibs is (was) part of the KDE Applications release, so sets kde-applications to get MASTER_SITES magic and such.

Mk/Uses/kde.mk
125 ↗(On Diff #40680)

^ @adridg, like here

portmgr, is this ok? It will just setup plist handling for the documentation files for all the ports that specific CATEGORIES=kde-applications.

That is do 5.16.4 centralised.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.