Differential D14781

regulator: Disable unused regulator
ClosedPublic
Actions

Authored by manu on Mar 21 2018, 9:16 AM.

Tags

None

Referenced Files

	F174029109: D14781.id40529.diff
	Wed, Sep 30, 2:19 AM

	F174023306: D14781.id40531.diff
	Wed, Sep 30, 1:20 AM

	F174023117: D14781.id41072.diff
	Wed, Sep 30, 1:18 AM

	F174010683: D14781.diff
	Tue, Sep 29, 11:13 PM

	Unknown Object (File)
	Mon, Sep 21, 2:29 PM

	Unknown Object (File)
	Fri, Sep 11, 4:20 PM

	Unknown Object (File)
	Wed, Sep 2, 4:19 AM

	Unknown Object (File)
	Wed, Sep 2, 4:07 AM

Subscribers

Details

Reviewers

Group Reviewers

ARM
arm64

Commits

rS331989: regulator: Disable unused regulator

Summary

bootloaders such as u-boot might enable regulators, or simply regulators could be enabled by default by the PMIC, even if we don't have a driver for the device or subsystem.
Disable unused regulators just before going to userland.
A tunable hw.regulator.disable_unused is added to not disable them in case this causes problems on some board but the default behavior is to disable everything unused. I prefer to break thinks now and fix them rather than never switch to the case were we disable regulators.

Test Plan

Tested on : Pine64-LTS (an idle board goes from ~0.33A to ~0.27A)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Mar 21 2018, 9:16 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 21 2018, 9:16 AM

Harbormaster completed remote builds in B15678: Diff 40529.Mar 21 2018, 9:16 AM

It would pay to add a comment to explain what the function is for.

Add comment explaining what the function does.

Harbormaster completed remote builds in B15680: Diff 40531.Mar 21 2018, 12:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 4 2018, 6:44 AM

Closed by commit rS331989: regulator: Disable unused regulator (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

extres/

regulator/

31 lines

Diff 41072

head/sys/dev/extres/regulator/regulator.c

Loading...