Page MenuHomeFreeBSD
Differential D14671

Reject ioctls to SCSI enclosures from 32-bit compat processes.
ClosedPublic
Actions

Authored by brooks on Mar 12 2018, 8:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 11:06 PM
Unknown Object (File)
Jan 13 2024, 3:37 AM
Unknown Object (File)
Dec 22 2023, 9:36 PM
Unknown Object (File)
Aug 22 2023, 6:06 PM
Unknown Object (File)
Aug 10 2023, 6:59 AM
Unknown Object (File)
Jun 14 2023, 1:40 AM
Unknown Object (File)
May 8 2023, 3:50 AM
Unknown Object (File)
Apr 25 2023, 6:14 PM
View All 13 Files
Subscribers
None

Details

Reviewers
scottl
kib
mav
ken
imp
Commits
rS331633: MFC r330820:
rS331631: MFC r330820:
rS330820: Reject ioctls to SCSI enclosures from 32-bit compat processes.
Summary

The ioctl objects contain pointers and require translation and some
refactoring of the infrastructure to work. For now prevent opertion on
garbage values. This is very slightly overbroad in that ENCIOC_INIT is
safe.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Mar 12 2018, 8:16 PM
Harbormaster completed remote builds in B15524: Diff 40218.Mar 12 2018, 8:16 PM
imp accepted this revision.Mar 12 2018, 8:25 PM

As my cats say: "If the box don't fits, I don't sits"

But if there's no way the ioctl could work, this is the right course of action.

This revision is now accepted and ready to land.Mar 12 2018, 8:25 PM
kib accepted this revision.Mar 12 2018, 9:41 PM
kib added inline comments.
sys/cam/scsi/scsi_enc.c
363 ↗(On Diff #40218)

space before '('.

brooks marked an inline comment as done.Mar 12 2018, 11:00 PM

Will fix missing space in commit. Thanks!

Closed by commit rS330820: Reject ioctls to SCSI enclosures from 32-bit compat processes. (authored by brooks). · Explain WhyMar 12 2018, 11:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cam/
scsi/
8 lines

Diff 40229

View Options

head/sys/cam/scsi/scsi_enc.c

Loading...