add -e flag to install(1)

[swills]

Summary

This adds a -e flag to install(1) which will cause it to error if it fails to install the file with the owner/permissions requested. This is an updated version of the patch from vwe@ for bugzilla PR 139314

Test Plan

Build test fine, may want ports exp-run, although ports calls install as root user by default, so shouldn't trigger an issue. May need manual testing.

[brooks]

Looks good to me. -e doesn't conflict with Linux.

[brooks]

Oh install.1 needs a .Dd bump.

[swills]

Add Dd bump

[swills]

Clarify that error can be produced for failure to set owner or mode.

[jilles]

This patch only affects the -d case. Failure to change owner and modes when installing regular files is fatal in any case. Perhaps the directory case should work the same way?

Also note that instantly exiting is not the usual way to handle errors on single files in POSIX utilities (which install admittedly is not). Utilities like cp and rm continue with the next file after an error on a file; the final exit status reflects whether there was any error.

usr.bin/xinstall/install.1

127–130

Contractions tend not to be used in man pages. The textproc/igor tool may be helpful to find this and other issues.

[0mp]

What's the status of this change?

[jilles]

I would like to see a consistent behaviour in handling chown/chmod failures between creating directories and installing files. A -e flag looks ugly and should only be added if both behaviours are necessary in different situations.