Page MenuHomeFreeBSD
Differential D14516

Only check the ProducerConsumer flag on extended memory
ClosedPublic
Actions

Authored by andrew on Feb 26 2018, 9:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 1:19 AM
Unknown Object (File)
Sun, Sep 6, 11:23 PM
Unknown Object (File)
Sun, Sep 6, 5:15 AM
Unknown Object (File)
Fri, Sep 4, 12:42 PM
Unknown Object (File)
Fri, Sep 4, 5:26 AM
Unknown Object (File)
Thu, Sep 3, 2:16 PM
Unknown Object (File)
Thu, Sep 3, 1:01 PM
Unknown Object (File)
Wed, Sep 2, 1:41 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
jkim
jhb
Commits
rS330113: Only check the ProducerConsumer flag on extended memory. As per the ACPI
Summary

As per the ACPI 6.0 spec 6.4.3.5 bit 0 is ignored on QWord, DWord, and Word
Address Space Descriptors, but not Extended Address Space Descriptors.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Feb 26 2018, 9:37 AM
Harbormaster completed remote builds in B15274: Diff 39740.Feb 26 2018, 9:37 AM
jhb accepted this revision.Feb 26 2018, 5:58 PM
jhb added inline comments.
sys/dev/acpica/acpi_resource.c
346 ↗(On Diff #39740)

I would check res->Type first before checking the flag.

This revision is now accepted and ready to land.Feb 26 2018, 5:58 PM
Closed by commit rS330113: Only check the ProducerConsumer flag on extended memory. As per the ACPI (authored by andrew). · Explain WhyFeb 28 2018, 3:18 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2018, 3:18 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
acpica/
3 lines

Diff 39827

View Options

head/sys/dev/acpica/acpi_resource.c

Loading...