The Arm pl011 driver assumes it's running a devicetree based system.
It calls OF_* functions to check if it needs to implement workarounds.
This may not be the case on arm64 where we support both FDT and ACPI.
Fix this by checking if we are booting on FDT before calling these checks.
Details
Details
- Reviewers
• ian - Group Reviewers
ARM arm64 - Commits
- rS330111: The Arm pl011 driver assumes it's running a devicetree based system.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This looks fine to me.
It seems slightly more obfuscatory to me to split out IS_FDT and uart_pl011_bus_hwrev_fdt vs a couple of ifdefs in uart_pl011_bus_probe (although I don't object).