Page MenuHomeFreeBSD

Support both FDT and ACPI on arm64 in the pl011 driver
ClosedPublic

Authored by andrew on Feb 26 2018, 8:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 3:26 AM
Unknown Object (File)
Dec 11 2023, 2:54 AM
Unknown Object (File)
Nov 22 2023, 6:34 PM
Unknown Object (File)
Oct 19 2023, 9:15 PM
Unknown Object (File)
Sep 6 2023, 5:42 AM
Unknown Object (File)
Sep 6 2023, 5:42 AM
Unknown Object (File)
Sep 6 2023, 5:39 AM
Unknown Object (File)
Sep 1 2023, 4:46 AM
Subscribers

Details

Summary

The Arm pl011 driver assumes it's running a devicetree based system.
It calls OF_* functions to check if it needs to implement workarounds.
This may not be the case on arm64 where we support both FDT and ACPI.
Fix this by checking if we are booting on FDT before calling these checks.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks fine to me.

It seems slightly more obfuscatory to me to split out IS_FDT and uart_pl011_bus_hwrev_fdt vs a couple of ifdefs in uart_pl011_bus_probe (although I don't object).

This revision is now accepted and ready to land.Feb 27 2018, 5:30 PM
This revision was automatically updated to reflect the committed changes.