Page MenuHomeFreeBSD

Move new IVHD definitions out of ACPI
ClosedPublic

Authored by anish on Feb 25 2018, 2:57 AM.

Details

Summary
  • Move the new AMD-Vi IVHD [ACPI_IVRS_HARDWARE_NEW]definitions added in r329360 in contrib ACPI to local files till ACPI code adds new definitions.
  • Rename ACPI_IVRS_HARDWARE_NEW to ACPI_IVRS_HARDWARE_EFRSUP, since new definitions add Extended Feature Register support.
  • Use IvrsType to distinguish three types of IVHD - 0x10(legacy), 0x11 and 0x40(with EFR). IVHD 0x40 is also called mixed type since it supports HID device entries.
  • Fix couple of Coverity bugs including a typo.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anish created this revision.Feb 25 2018, 2:57 AM
anish edited the summary of this revision. (Show Details)Feb 25 2018, 2:58 AM
grehan added inline comments.Feb 25 2018, 10:40 PM
sys/amd64/vmm/amd/amdvi_priv.h
360 ↗(On Diff #39697)

typos: New IVHD types 0x11 and 0x40 as defined

375 ↗(On Diff #39697)

Should there be a CTASSERT for this struct size ? Looks like it could need to be __packed.

anish updated this revision to Diff 39943.Mar 4 2018, 5:24 PM

Added CTASSERT check for new IVHD definitions.

grehan accepted this revision.Mar 4 2018, 5:26 PM
This revision is now accepted and ready to land.Mar 4 2018, 5:26 PM
This revision was automatically updated to reflect the committed changes.