Differential D14501

Move new IVHD definitions out of ACPI
ClosedPublic
Actions

Authored by anish on Feb 25 2018, 2:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 30, 3:16 PM

	Unknown Object (File)
	Tue, Sep 30, 1:54 PM

	Unknown Object (File)
	Tue, Sep 30, 9:25 AM

	Unknown Object (File)
	Tue, Sep 30, 3:33 AM

	Unknown Object (File)
	Tue, Sep 30, 12:15 AM

	Unknown Object (File)
	Tue, Sep 30, 12:02 AM

	Unknown Object (File)
	Fri, Sep 26, 7:30 PM

	Unknown Object (File)
	Fri, Sep 26, 1:24 PM

View All 97 Files

Subscribers

Details

Reviewers

grehan
cem
jkim
rgrimes

Group Reviewers

Commits

rS330439: Move the new AMD-Vi IVHD [ACPI_IVRS_HARDWARE_NEW]definitions added in r329360…

Summary

Move the new AMD-Vi IVHD [ACPI_IVRS_HARDWARE_NEW]definitions added in r329360 in contrib ACPI to local files till ACPI code adds new definitions.
Rename ACPI_IVRS_HARDWARE_NEW to ACPI_IVRS_HARDWARE_EFRSUP, since new definitions add Extended Feature Register support.
Use IvrsType to distinguish three types of IVHD - 0x10(legacy), 0x11 and 0x40(with EFR). IVHD 0x40 is also called mixed type since it supports HID device entries.
Fix couple of Coverity bugs including a typo.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

anish created this revision.Feb 25 2018, 2:57 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 25 2018, 2:57 AM

anish edited the summary of this revision. (Show Details)Feb 25 2018, 2:58 AM

grehan added inline comments.Feb 25 2018, 10:40 PM

sys/amd64/vmm/amd/amdvi_priv.h
360 ↗	(On Diff #39697)	typos: New IVHD types 0x11 and 0x40 as defined
375 ↗	(On Diff #39697)	Should there be a CTASSERT for this struct size ? Looks like it could need to be __packed.

Added CTASSERT check for new IVHD definitions.

Herald added a reviewer: rgrimes. · View Herald TranscriptMar 4 2018, 5:24 PM

grehan accepted this revision.Mar 4 2018, 5:26 PM

This revision is now accepted and ready to land.Mar 4 2018, 5:26 PM

Closed by commit rS330439: Move the new AMD-Vi IVHD [ACPI_IVRS_HARDWARE_NEW]definitions added in r329360… (authored by anish). · Explain WhyMar 5 2018, 2:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

vmm/

amd/

33 lines

74 lines

contrib/

dev/

acpica/

include/

17 lines

Diff 39949

head/sys/amd64/vmm/amd/amdvi_priv.h

Loading...

head/sys/amd64/vmm/amd/ivrs_drv.c

Loading...

head/sys/contrib/dev/acpica/include/actbl2.h

Loading...