Page MenuHomeFreeBSD

Add menu.lua(8), but do not add to distribution
ClosedPublic

Authored by kevans on Feb 23 2018, 3:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 3:59 AM
Unknown Object (File)
Nov 14 2023, 4:37 AM
Unknown Object (File)
Nov 11 2023, 11:46 AM
Unknown Object (File)
Nov 10 2023, 10:49 AM
Unknown Object (File)
Nov 9 2023, 8:19 PM
Unknown Object (File)
Nov 7 2023, 8:24 AM
Unknown Object (File)
Oct 13 2023, 3:38 AM
Unknown Object (File)
Oct 10 2023, 10:49 AM
Subscribers

Details

Summary

Distribution will be done after all of the lualoader manpages are created.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rpokala added inline comments.
stand/lua/menu.lua.8
1 ↗(On Diff #39635)

Don't forget the SPDX tag.

34 ↗(On Diff #39635)

You can drop this fragment; I think it's okay to just start with the name of the file.

38 ↗(On Diff #39635)

influenced by loader environment variables.

As opposed to environment variables at build-time. That might be clear to most people, but make it explicit.

51 ↗(On Diff #39635)

Since "entries" starts with a vowel sound, this should be "contain an".

57 ↗(On Diff #39635)

I think "If the value of the entries key is itself a table" reads a bit cleaner.

76 ↗(On Diff #39635)

You should define or describe "carousel".

85 ↗(On Diff #39635)

"A table (or a lambda that returns a table) of the possible choices for this carousel."

I think that reads a little better.

88 ↗(On Diff #39635)

Same.

168 ↗(On Diff #39635)

I think the ".It Pa /boot/lua/menu.lua" and ".Nm" lines aren't meant to be here...?

kevans marked 9 inline comments as done.
  • Address some concerns from @rpokala
  • Update examples to match current style
stand/lua/menu.lua.8
176 ↗(On Diff #39638)

My eyes are rendering this as:

The loader(8) /boot/lua/loader.lua loader(8) bootstrapping script.

Which still doesn't look right.

I've ripped out the FILES section entirely. This was a holdover from the 4th manpages, but it likely belongs elsewhere that describes the entirety of lualoader. There's not exactly only one loader that this stuff will be applicable to anyways, so it wasn't entirely accurate.

This revision is now accepted and ready to land.Mar 2 2018, 5:06 AM
This revision was automatically updated to reflect the committed changes.