Page MenuHomeFreeBSD

Add core.lua(8), but do not add to distribution
ClosedPublic

Authored by kevans on Feb 23 2018, 3:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 28, 2:22 AM
Unknown Object (File)
Aug 25 2025, 10:16 AM
Unknown Object (File)
Jul 27 2025, 1:46 AM
Unknown Object (File)
Jul 7 2025, 1:09 PM
Unknown Object (File)
Jul 6 2025, 6:24 PM
Unknown Object (File)
Jul 4 2025, 7:17 AM
Unknown Object (File)
Jul 3 2025, 2:02 AM
Unknown Object (File)
Jun 26 2025, 7:31 PM
Subscribers

Details

Summary

Distribution will be done after all of the lualoader manpages are created.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 15229

Event Timeline

stand/lua/core.lua.8
2

I've got the SPDX addition queued up, I'll update following any feedback. =)

stand/lua/core.lua.8
35

As with menu.lua(8), drop this opening fragment.

81

Rotate how? Left/right arrow keys?

109

Avoid the double-negative:

This will only be accurate for i386-compatible systems.

Also, is it really "i386-compatible", or also amd64? i.e. should it be "x86-compatible?

115

Is "Set the ACPI settings." still talking about core.getACPIPresent? I think you might have left out a line here...

196

As before, i386 or x86?

207

s/,/;/

kevans marked 3 inline comments as done.

Address some concerns raised by @rpokala

stand/lua/core.lua.8
109

I've expanded that a little bit more. It applies to i386 and amd64 non-UEFI loaders, since these are compiled as i386.

115

Whoops, I must have dropped it when i was playing around with the formatting.

stand/lua/core.lua.8
96

Line 96 should be removed now that lines 97-98 are there.

103

Same thing; 103 should be removed because 104-105 are present.

119

And again; nix 119 because 120-124.

This revision is now accepted and ready to land.Mar 2 2018, 5:29 AM
This revision was automatically updated to reflect the committed changes.