Paths

Table of Contentst

Differential D14479

Add core.lua(8), but do not add to distribution
ClosedPublic
Actions

Authored by kevans on Feb 23 2018, 3:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 10 2024, 9:56 PM

	Unknown Object (File)
	Dec 23 2023, 12:04 PM

	Unknown Object (File)
	Dec 5 2023, 5:26 PM

	Unknown Object (File)
	Nov 16 2023, 3:49 PM

	Unknown Object (File)
	Nov 10 2023, 4:20 PM

	Unknown Object (File)
	Nov 8 2023, 11:11 PM

	Unknown Object (File)
	Nov 8 2023, 8:26 AM

	Unknown Object (File)
	Nov 7 2023, 10:34 AM

View All 36 Files

Subscribers

Details

Reviewers

cem
rpokala

Group Reviewers

Commits

rS330267: Add core.lua(8), but do not add to distribution

Summary

Distribution will be done after all of the lualoader manpages are created.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Feb 23 2018, 3:32 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2018, 3:32 AM

kevans added a reviewer: rpokala.Feb 23 2018, 4:29 AM

kevans added inline comments.Feb 23 2018, 4:45 AM

stand/lua/core.lua.8
1 ↗	(On Diff #39634)	I've got the SPDX addition queued up, I'll update following any feedback. =)

rpokala added inline comments.Feb 23 2018, 5:06 AM

stand/lua/core.lua.8
34 ↗	(On Diff #39634)	As with menu.lua(8), drop this opening fragment.
80 ↗	(On Diff #39634)	Rotate how? Left/right arrow keys?
108 ↗	(On Diff #39634)	Avoid the double-negative: This will only be accurate for i386-compatible systems. Also, is it really "i386-compatible", or also amd64? i.e. should it be "x86-compatible?
114 ↗	(On Diff #39634)	Is "Set the ACPI settings." still talking about `core.getACPIPresent`? I think you might have left out a line here...
195 ↗	(On Diff #39634)	As before, i386 or x86?
206 ↗	(On Diff #39634)	s/,/;/

Address some concerns raised by @rpokala

stand/lua/core.lua.8
108 ↗	(On Diff #39634)	I've expanded that a little bit more. It applies to i386 and amd64 non-UEFI loaders, since these are compiled as i386.
114 ↗	(On Diff #39634)	Whoops, I must have dropped it when i was playing around with the formatting.

rpokala added inline comments.Mar 2 2018, 5:01 AM

stand/lua/core.lua.8
96 ↗	(On Diff #39654)	Line 96 should be removed now that lines 97-98 are there.
103 ↗	(On Diff #39654)	Same thing; 103 should be removed because 104-105 are present.
119 ↗	(On Diff #39654)	And again; nix 119 because 120-124.

Remove redundancy

rpokala accepted this revision as: rpokala.Mar 2 2018, 5:29 AM

This revision is now accepted and ready to land.Mar 2 2018, 5:29 AM

Closed by commit rS330267: Add core.lua(8), but do not add to distribution (authored by kevans). · Explain WhyMar 2 2018, 5:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

lua/

222 lines

Diff 39876

head/stand/lua/core.lua.8

Loading...