Page MenuHomeFreeBSD

Implement .vop_pathconf and .vop_getacl for the .zfs ctldir
ClosedPublic

Authored by asomers on Feb 14 2018, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 13 2024, 3:40 AM
Unknown Object (File)
Dec 23 2023, 12:40 AM
Unknown Object (File)
Nov 6 2023, 5:37 AM
Unknown Object (File)
Oct 5 2023, 4:17 AM
Unknown Object (File)
Jun 6 2023, 12:04 AM
Unknown Object (File)
Nov 26 2022, 9:25 PM
Subscribers

Details

Summary

Implement .vop_pathconf and .vop_getacl for the .zfs ctldir

zfsctl_pathconf will report all the same variables that regular ZFS volumes
report. zfs_common_getacl will report an ACL equivalent to 555, except that
you can't read xattrs or edit attributes.

Fixes a bug where "ls .zfs" will occasionally print something like:
ls: .zfs/.: Operation not supported

PR: 225793

Test Plan

snapshot_018_pos from the ZFS test suite

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15036
Build 15137: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 14 2018, 12:51 PM

BTW, this bug long predated your big ctldir refactor. AFAIK, it's always been present in FreeBSD. I'm not sure about Illumos. I actually fixed it at work back in 2013, but the change slipped through the cracks and I didn't push it upstream.

This revision was automatically updated to reflect the committed changes.

BTW, this bug long predated your big ctldir refactor. AFAIK, it's always been present in FreeBSD. I'm not sure about Illumos. I actually fixed it at work back in 2013, but the change slipped through the cracks and I didn't push it upstream.

Yeah... I noticed bug 153142 a while ago, it seemed a like trivial issue, but never got around to it.
You might want to claim that bug now :) Thank you for the fix!