Page MenuHomeFreeBSD
Differential D14365

Implement .vop_pathconf and .vop_getacl for the .zfs ctldir
ClosedPublic
Actions

Authored by asomers on Feb 14 2018, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 2:01 AM
Unknown Object (File)
Wed, Dec 11, 1:59 AM
Unknown Object (File)
Tue, Dec 10, 6:50 AM
Unknown Object (File)
Sun, Dec 1, 2:31 AM
Unknown Object (File)
Oct 3 2024, 10:29 AM
Unknown Object (File)
Oct 3 2024, 8:43 AM
Unknown Object (File)
Oct 1 2024, 1:24 PM
Unknown Object (File)
Sep 25 2024, 10:17 AM
View All 37 Files
Subscribers
delphij
imp

Details

Reviewers
avg
Commits
rS330736: MFC r329265, r329384
rS330732: MFC r329265, r329384
rS329265: Implement .vop_pathconf and .vop_getacl for the .zfs ctldir
Summary

Implement .vop_pathconf and .vop_getacl for the .zfs ctldir

zfsctl_pathconf will report all the same variables that regular ZFS volumes
report. zfs_common_getacl will report an ACL equivalent to 555, except that
you can't read xattrs or edit attributes.

Fixes a bug where "ls .zfs" will occasionally print something like:
ls: .zfs/.: Operation not supported

PR: 225793

Test Plan

snapshot_018_pos from the ZFS test suite

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Feb 14 2018, 12:23 AM
Harbormaster completed remote builds in B15036: Diff 39289.Feb 14 2018, 12:23 AM
Herald added subscribers: delphij, imp. · View Herald TranscriptFeb 14 2018, 12:23 AM
avg accepted this revision.Feb 14 2018, 12:51 PM

LGTM. Thank you!

This revision is now accepted and ready to land.Feb 14 2018, 12:51 PM
asomers added a comment.Feb 14 2018, 3:47 PM

BTW, this bug long predated your big ctldir refactor. AFAIK, it's always been present in FreeBSD. I'm not sure about Illumos. I actually fixed it at work back in 2013, but the change slipped through the cracks and I didn't push it upstream.

Closed by commit rS329265: Implement .vop_pathconf and .vop_getacl for the .zfs ctldir (authored by asomers). · Explain WhyFeb 14 2018, 3:49 PM
This revision was automatically updated to reflect the committed changes.
avg added a comment.Feb 14 2018, 4:56 PM
In D14365#301118, @asomers wrote:

BTW, this bug long predated your big ctldir refactor. AFAIK, it's always been present in FreeBSD. I'm not sure about Illumos. I actually fixed it at work back in 2013, but the change slipped through the cracks and I didn't push it upstream.

Yeah... I noticed bug 153142 a while ago, it seemed a like trivial issue, but never got around to it.
You might want to claim that bug now :) Thank you for the fix!

Revision Contents
Changeset List

PathSize
head/
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
92 lines

Diff 39304

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c

Loading...