crossbuild: make mkioctls script work on Linux and MacOS
ClosedPublic
Actions

Authored by arichardson on Feb 7 2018, 4:59 PM.

Details

Reviewers

emaste
jhb
imp
bdrewery

Commits

rS338095: Make mkioctls script work on Linux and MacOS

Summary

Using find -s will not work with the Linux or MacOS find command. We pipe
to sort instead since the only real requirement here is that the order
stays the same. While I am touching this file I also fixed a == construct
which is not supported by POSIX sh but appears to work on FreeBSD.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14849
Build 14963: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 7 2018, 4:59 PM

Harbormaster completed remote builds in B14849: Diff 39010.Feb 7 2018, 4:59 PM

imp accepted this revision.Feb 7 2018, 5:03 PM

This revision is now accepted and ready to land.Feb 7 2018, 5:03 PM

emaste added inline comments.Feb 7 2018, 7:24 PM

lib/libsysdecode/mkioctls
22	Perhaps `grep -q` is portable?
22	Interesting, I wonder how this snuck in here.

jhb accepted this revision.Feb 8 2018, 7:25 PM

jhb added inline comments.

lib/libsysdecode/mkioctls
21	Minor nit: Since the comments are sentences, capitalize the first word and add punctuation.
30	Punctuation here as well.

use grep -q
make it actually work with pipefail by excluding dangling symlinks. Those would cause egrep to return non-zero and with pipefail fail the whole subshell.

This revision now requires review to proceed.Feb 11 2018, 10:35 AM

Harbormaster completed remote builds in B14952: Diff 39171.Feb 11 2018, 10:35 AM

One last nit, and then I think we're good to go.