Page MenuHomeFreeBSD

BCM2835 (Raspberry Pi 3) sdhost device driver
ClosedPublic

Authored by k_7he.at on Feb 2 2018, 10:46 AM.
Tags
None
Referenced Files
F135849510: D14168.id38776.diff
Thu, Nov 13, 12:25 PM
Unknown Object (File)
Wed, Nov 5, 10:56 PM
Unknown Object (File)
Mon, Oct 27, 3:22 AM
Unknown Object (File)
Mon, Oct 27, 1:30 AM
Unknown Object (File)
Sun, Oct 26, 4:40 PM
Unknown Object (File)
Sun, Oct 26, 12:29 AM
Unknown Object (File)
Sat, Oct 25, 11:14 PM
Unknown Object (File)
Sat, Oct 25, 5:50 PM

Details

Summary

This is a device driver for the second SDHCI on Raspberry Pi 3 / BCM2835.
It allows the Arasan SDHCI to be used for other purposes, e.g. driving
the radio (wlan) module.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/arm/broadcom/bcm2835/bcm2835_sdhost.c
263 ↗(On Diff #38776)

As it was previously discussed on mailing list, direct gpio pin muxing should be replaced by proper pinctrl. It's in review at the moment , D14104. I added dependency for this review.

538 ↗(On Diff #38776)

It's OK in some cases to prevent detach of the device with EBUSY but in this case do not destroy mutex, because it's still going to be required.

  • Removed all of the ''swap pins'' stuff.
  • Not destroying the mutex in bcm_sdhost_detach().
  • Added comment about pin configurations. Without the pull-ups the card will not be recognized !
sys/arm/broadcom/bcm2835/bcm2835_sdhost.c
405 ↗(On Diff #39706)

This variable (and the one after) are not used and cause compilation to fail.

Removed unused variables ''node'' and ''cell'' in bcm_sdhost_attach().

This revision is now accepted and ready to land.Jun 28 2018, 6:14 PM
This revision was automatically updated to reflect the committed changes.