Page MenuHomeFreeBSD
Differential D14157

crossbuild: Make the CHECK_TIME variable work on Linux
ClosedPublic
Actions

Authored by arichardson on Feb 1 2018, 2:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 24, 3:13 AM
Unknown Object (File)
Fri, Nov 21, 2:49 AM
Unknown Object (File)
Fri, Nov 21, 2:46 AM
Unknown Object (File)
Fri, Nov 21, 2:43 AM
Unknown Object (File)
Fri, Nov 21, 2:32 AM
Unknown Object (File)
Fri, Nov 21, 2:30 AM
Unknown Object (File)
Mon, Nov 17, 7:09 PM
Unknown Object (File)
Wed, Nov 12, 7:48 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
jhb
imp
bdrewery
Commits
rS328935: crossbuild: Make the CHECK_TIME variable work on Linux
Summary

Linux /usr/bin/find doesn't understand the -mtime -0s flag.
Instead create a temporary file and compare that file's mtime to
sys/sys/param.h to check whether the clock is correct.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14790
Build 14909: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 1 2018, 2:20 PM
Harbormaster completed remote builds in B14727: Diff 38756.Feb 1 2018, 2:20 PM
arichardson added a reviewer: bdrewery.Feb 4 2018, 8:39 PM
imp added inline comments.Feb 4 2018, 8:49 PM
Makefile
360

This is now wrong. This changes from 0s to 0 days. Due to funky roundings, this tests to see if the sys/sys/param.h file is one day or less old (or in the future), whereas on FreeBSD it tests if it is 1 second old or in the future. The difference is important and will lead to false positives.

"touch /tmp/junk && find ${.CURDIR}/sys/sys/param.h -newer /tmp/junk && rm /tmp/junk" would do the same thing and be portable...

arichardson updated this revision to Diff 38884.Feb 5 2018, 1:11 PM
arichardson edited the summary of this revision. (Show Details)

Use a temporary file instead

imp accepted this revision.Feb 5 2018, 5:12 PM
imp added inline comments.
Makefile
355

Thanks!

This revision is now accepted and ready to land.Feb 5 2018, 5:12 PM
jhb accepted this revision.Feb 5 2018, 6:13 PM
Closed by commit rS328935: crossbuild: Make the CHECK_TIME variable work on Linux (authored by arichardson). · Explain WhyFeb 6 2018, 3:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines

Diff 38884

View Options

Makefile

Loading...