www/mod_security-devel: Update to latest pre-release and rename it to www/mod_security3

[joneum]

Summary

www/mod_security-devel: Update to latest pre-release and rename it to www/mod_security3

*While here:

• Switch to DISTVERSION
• Pet portlint
• Add PKGNAMESUFFIX

PR: 222877
Submitted by: Marius Halden <[e-mail]> (maintainer)

Approved by: maintainer timeout (2 weeks) xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

http://joneumbox.org/build.html?mastername=10amd64-ports&build=2018-01-29_07h04m03s
http://joneumbox.org/build.html?mastername=10i386-ports&build=2018-01-29_07h04m03s

http://joneumbox.org/build.html?mastername=11-1-AMD64-ports&build=2018-01-29_09h35m09s
http://joneumbox.org/build.html?mastername=11-1-i386-ports&build=2018-01-29_09h37m36s

http://joneumbox.org/build.html?mastername=12amd64-ports&build=2018-01-29_09h39m31s
http://joneumbox.org/build.html?mastername=12i386-ports&build=2018-01-29_09h41m49s

~...www/mod_security3: portlint -AC [17:26:58]
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

[tcberner]

www/mod_security3/Makefile

3 ↗

(On Diff #38625)

^ that seems wrong

[joneum]

set correct PORTNAME

[joneum]

set correct PORTNAME=

[joneum]

ping @tz @rene @tcberner

[mat]

Why rename it?

[mat]

Oh, sorry, I missed it was -devel.

[tcberner]

@joneum, could you update the diff, as it does not seem to apply at the moment

[tcberner]

Apart from that, it looks fine...

[tcberner]

www/mod_security3/Makefile

13 ↗

(On Diff #38630)

https://github.com/SpiderLabs/ModSecurity/commit/968d83f1ff688c8158a3fe1c2fc375dd8548b97c

I think this should be fixed in v3 -- maybe worth checking if that commit is in.

[joneum]

In D14118#298449, @tcberner wrote:

@joneum, could you update the diff, as it does not seem to apply at the moment

what is not okay? I think it only affects www/Makefile - and that changes again until the commit. If there are no other problems, you can approved it and I will customize www/Makefile if it is committed.

[joneum]

or MOVED .... but i think, the same why www/Makefile

[joneum]

www/mod_security3/Makefile

13 ↗

(On Diff #38630)

good point ... i will remove this 2 lines tomorrow ... now time to sleep

[joneum]

Delete BROKEN_* lines. after Update modsecurity3, this will build now, see: https://github.com/SpiderLabs/ModSecurity/commit/968d83f1ff688c8158a3fe1c2fc375dd8548b97c

New into this review is the adaptation of NGINX to the modification of modsecurity3

NGINX will extra committed

[mat]

www/mod_security3/Makefile

3–6 ↗

(On Diff #39137)

This is going to be called mod_security-devel3. Is that the intended behavior?

[joneum]

set correct PORTNAME, remove "devel" from it

[joneum]

www/mod_security3/Makefile

3–6 ↗

(On Diff #39137)

thanks for the hint. I will set PORTNAME correct

[joneum]

ping @tz @rene @tcberner

[tcberner]

MOVED

9921 ↗

(On Diff #39138)

^Remember to update the date

[tcberner]

Hm, you do not seem to have committed what was in here?

[joneum]

In D14118#300251, @tcberner wrote:

Hm, you do not seem to have committed what was in here?

look at head/www/mod_security3/Makefile

There is, I have no idea why, no more PKGNAMESUFFIX
So I have actually committed exactly what is there ^ ^