Page MenuHomeFreeBSD

www/mod_security-devel: Update to latest pre-release and rename it to www/mod_security3
ClosedPublic

Authored by joneum on Jan 29 2018, 4:27 PM.

Details

Summary

www/mod_security-devel: Update to latest pre-release and rename it to www/mod_security3

*While here:

  • Switch to DISTVERSION
  • Pet portlint
  • Add PKGNAMESUFFIX

PR: 222877
Submitted by: Marius Halden <marius.h@lden.org> (maintainer)

Approved by: maintainer timeout (2 weeks) xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner added inline comments.
www/mod_security3/Makefile
3 ↗(On Diff #38625)

^ that seems wrong

This revision now requires changes to proceed.Jan 29 2018, 5:46 PM

Oh, sorry, I missed it was -devel.

@joneum, could you update the diff, as it does not seem to apply at the moment

Apart from that, it looks fine...

www/mod_security3/Makefile
13 ↗(On Diff #38630)

https://github.com/SpiderLabs/ModSecurity/commit/968d83f1ff688c8158a3fe1c2fc375dd8548b97c

I think this should be fixed in v3 -- maybe worth checking if that commit is in.

@joneum, could you update the diff, as it does not seem to apply at the moment

what is not okay? I think it only affects www/Makefile - and that changes again until the commit. If there are no other problems, you can approved it and I will customize www/Makefile if it is committed.

or MOVED .... but i think, the same why www/Makefile

www/mod_security3/Makefile
13 ↗(On Diff #38630)

good point ... i will remove this 2 lines tomorrow ... now time to sleep

Delete BROKEN_* lines. after Update modsecurity3, this will build now, see: https://github.com/SpiderLabs/ModSecurity/commit/968d83f1ff688c8158a3fe1c2fc375dd8548b97c

New into this review is the adaptation of NGINX to the modification of modsecurity3

NGINX will extra committed

www/mod_security3/Makefile
3–6 ↗(On Diff #39137)

This is going to be called mod_security-devel3. Is that the intended behavior?

set correct PORTNAME, remove "devel" from it

www/mod_security3/Makefile
3–6 ↗(On Diff #39137)

thanks for the hint. I will set PORTNAME correct

tcberner added inline comments.
MOVED
9921 ↗(On Diff #39138)

^Remember to update the date

This revision is now accepted and ready to land.Feb 11 2018, 8:24 PM
This revision was automatically updated to reflect the committed changes.

Hm, you do not seem to have committed what was in here?

Hm, you do not seem to have committed what was in here?

look at head/www/mod_security3/Makefile

There is, I have no idea why, no more PKGNAMESUFFIX
So I have actually committed exactly what is there ^ ^