Page MenuHomeFreeBSD

Reduce code duplication for inpcb route caching
ClosedPublic

Authored by rstone on Jan 19 2018, 9:40 PM.

Details

Summary

Add a new macro to clear both the L3 and L2 route caches, to
hopefully prevent future instances where only the L3 cache was
cleared when both should have been.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rstone created this revision.Jan 19 2018, 9:40 PM
vangyzen added inline comments.
sys/net/route.h
419 ↗(On Diff #38222)

I generally prefer inline functions over macros, but this is fine.

sys/netinet/ip_output.c
305 ↗(On Diff #38222)

This drops the assignment of NULL to the local rte.

rstone updated this revision to Diff 38234.Jan 19 2018, 11:36 PM

NULL-out rte after route cache is invalidated

rstone marked 2 inline comments as done.Jan 19 2018, 11:38 PM

Was there a place where only L3 was invalidated?

In any case, this seems like a good change.

karels accepted this revision.Jan 22 2018, 5:38 AM
This revision is now accepted and ready to land.Jan 22 2018, 5:38 AM
This revision was automatically updated to reflect the committed changes.