Page MenuHomeFreeBSD
Differential D13982

bnxt: Update man page with newly supported devices, options, ect
ClosedPublic
Actions

Authored by bhargava.marreddy_broadcom.com on Jan 19 2018, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 7:11 PM
Unknown Object (File)
Fri, Jan 24, 7:19 PM
Unknown Object (File)
Fri, Jan 24, 5:14 PM
Unknown Object (File)
Thu, Jan 23, 6:44 PM
Unknown Object (File)
Sun, Jan 5, 5:25 PM
Unknown Object (File)
Nov 22 2024, 2:57 AM
Unknown Object (File)
Nov 16 2024, 5:03 PM
Unknown Object (File)
Nov 12 2024, 6:30 PM
View All 57 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
siva.kallam_broadcom.com
shurd
sbruno
Group Reviewers
manpages
Commits
rS329335: bnxt: Update man page with newly supported devices, options, etc
Summary

update man page with

  • Newly supported devices
  • Newly added options
  • 'maintained by' Email ID
Test Plan

verified using 'man bnxt' command, o/p looks good

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14807
Build 14925: arc lint + arc unit

Event Timeline

bhargava.marreddy_broadcom.com created this revision.Jan 19 2018, 12:32 PM
Herald added a reviewer: manpages. · View Herald TranscriptJan 19 2018, 12:32 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
Harbormaster completed remote builds in B14479: Diff 38201.Jan 19 2018, 12:32 PM
bhargava.marreddy_broadcom.com edited the summary of this revision. (Show Details)Jan 19 2018, 12:36 PM
bhargava.marreddy_broadcom.com edited the test plan for this revision. (Show Details)
bhargava.marreddy_broadcom.com added reviewers: siva.kallam_broadcom.com, shurd, sbruno.
sbruno accepted this revision.Jan 19 2018, 6:02 PM
This revision is now accepted and ready to land.Jan 19 2018, 6:02 PM
imp added inline comments.Jan 19 2018, 7:05 PM
bnxt.4
79–87

These are all the same number. Is that intentional?

101

I don't think Broadcom should be repeated.

103

These are no longer sorted by BCM number. Perhaps they should be?

shurd added a comment.Jan 22 2018, 4:59 AM

Stephen Hurd did do a fair bit on this driver, so shouldn't have his name removed. :-)

bnxt.4
247–249

.An Jack Vogel Aq Mt jfvogel@gmail.com , and
.An Stephen Hurd Aq Mt shurd@freebsd.org ,

bhargava.marreddy_broadcom.com marked 3 inline comments as done.Jan 30 2018, 7:23 AM
bhargava.marreddy_broadcom.com added inline comments.
bnxt.4
79–87

Yes, that is intentional as device IDs (also speeds) are different.

101

I'll fix it.

103

Sure, let me sort it and resubmit.

247–249

Sure, let me modify and resubmit.

bhargava.marreddy_broadcom.com updated this revision to Diff 38933.Feb 6 2018, 12:24 PM
bhargava.marreddy_broadcom.com marked 3 inline comments as done.

Taken care of all review comments.

This revision now requires review to proceed.Feb 6 2018, 12:24 PM
Harbormaster completed remote builds in B14807: Diff 38933.Feb 6 2018, 12:24 PM
bhargava.marreddy_broadcom.com added inline comments.Feb 6 2018, 12:29 PM
bnxt.4
247–249

Stephen,

It looks like this now, can you please review.

AUTHORS

The bnxt driver was written by Jack Vogel <jfvogel@gmail.com> and Stephen
Hurd <shurd@freebsd.org>, and is currently maintained by Broadcom Limited
<freebsd.pdl@broadcom.com>.

shurd accepted this revision.Feb 8 2018, 8:13 PM

stlgtm

This revision is now accepted and ready to land.Feb 8 2018, 8:13 PM
Closed by commit rS329335: bnxt: Update man page with newly supported devices, options, etc (authored by shurd). · Explain WhyFeb 15 2018, 6:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
45 lines

Diff 38933

View Options

bnxt.4

Loading...