Page MenuHomeFreeBSD
Differential D13834

Make use of mallocarray in sys/netpfil/ipfw
ClosedPublic
Actions

Authored by pfg on Jan 10 2018, 8:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 12:52 PM
Unknown Object (File)
Mon, Apr 6, 9:49 AM
Unknown Object (File)
Wed, Mar 25, 2:02 AM
Unknown Object (File)
Sun, Mar 22, 4:49 AM
Unknown Object (File)
Mar 15 2026, 11:32 PM
Unknown Object (File)
Feb 28 2026, 6:26 AM
Unknown Object (File)
Feb 17 2026, 2:30 PM
Unknown Object (File)
Feb 14 2026, 8:03 PM
View All 94 Files
Subscribers
ae
imp

Details

Reviewers
kp
glebius
pfg
ae
Commits
rS327829: netpfil/ipfw: Make some use of mallocarray(9).
Summary

I found these cases where we can use mallocarray and since we are using
M_NOWAIT, the code is ready for the possibility of a NULL value returned.

Test Plan

Passed buildworld.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pfg created this revision.Jan 10 2018, 8:30 PM
Herald added subscribers: ae, imp. · View Herald TranscriptJan 10 2018, 8:30 PM
pfg edited the summary of this revision. (Show Details)Jan 10 2018, 8:31 PM
pfg edited the test plan for this revision. (Show Details)
kp accepted this revision.Jan 10 2018, 8:40 PM

ae@ is probably the best person to talk to about ipfw, so you may want to cc him too.

That said, this is pretty straightforward and it looks right to me.

This revision is now accepted and ready to land.Jan 10 2018, 8:40 PM
pfg accepted this revision.Jan 10 2018, 8:47 PM
pfg retitled this revision from Make use of mallocarray in sys/netpfil/ipfs to Make use of mallocarray in sys/netpfil/ipfw.
pfg added a reviewer: ae.
ae accepted this revision.Jan 10 2018, 11:24 PM

This looks like noop for me, so I have no objection.

Closed by commit rS327829: netpfil/ipfw: Make some use of mallocarray(9). (authored by pfg). · Explain WhyJan 11 2018, 3:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netpfil/
ipfw/
2 lines
4 lines
4 lines

Diff 37808

View Options

head/sys/netpfil/ipfw/dn_heap.c

Loading...
View Options

head/sys/netpfil/ipfw/dn_sched_fq_codel.c

Loading...
View Options

head/sys/netpfil/ipfw/dn_sched_fq_pie.c

Loading...