Details
- Reviewers
brueffer - Group Reviewers
manpages - Commits
- rS328471: Document the grp Casper service.
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
A few suggestions and corrections.
lib/libcasper/services/cap_grp/cap_grp.3 | ||
---|---|---|
117 ↗ | (On Diff #37711) | s/allows/allow/ maybe: ... which will allow to use the function associated with the name. |
136 ↗ | (On Diff #37711) | That sentence is hard to understand. The field which was set as the limit will be returned else it will be set to default values. |
146 ↗ | (On Diff #37711) | Is it just one group or groups (the variable says groups)? I think you mean to write this: The cap_grp_limit_groups function allows to limit access to groups. |
151 ↗ | (On Diff #37711) | How about this: The names variable allows to limit groups by name and the gids variable by the group number. |
156 ↗ | (On Diff #37711) | The "respectively" has to move at the end, like this: |
161 ↗ | (On Diff #37711) | s/an/a/ |
192 ↗ | (On Diff #37711) | s/Umable/Unable/ |
196 ↗ | (On Diff #37711) | Same here... |
200 ↗ | (On Diff #37711) | ... and here. |
lib/libcasper/services/cap_grp/cap_grp.3 | ||
---|---|---|
136 ↗ | (On Diff #37711) | So we have a stracture: struct group { const char *gr_name; const char *gr_passwd; etc. } So if i limit it casper to gr_name, I still will get whole structure but only gr_name will be filled from it. |
New suggestion on how to word it better, based on your explanation, @oshogbo.
I found something else while there, but it's easy to fix. ;-)
lib/libcasper/services/cap_grp/cap_grp.3 | ||
---|---|---|
106 ↗ | (On Diff #37723) | Just found this one: s/varlable/variable/ |
136 ↗ | (On Diff #37711) | Ah, thanks for the explanation. |
One more typo, looks good otherwise!
lib/libcasper/services/cap_grp/cap_grp.3 | ||
---|---|---|
202 ↗ | (On Diff #37940) | associated |