Page MenuHomeFreeBSD

Document cap_grp service.
ClosedPublic

Authored by oshogbo on Jan 10 2018, 4:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 5:06 AM
Unknown Object (File)
Mon, Apr 1, 3:09 PM
Unknown Object (File)
Fri, Mar 29, 3:19 PM
Unknown Object (File)
Feb 7 2024, 8:27 PM
Unknown Object (File)
Dec 21 2023, 6:03 AM
Unknown Object (File)
Nov 23 2023, 8:14 AM
Unknown Object (File)
Nov 21 2023, 8:15 AM
Unknown Object (File)
Nov 14 2023, 6:21 PM
Subscribers

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

oshogbo created this revision.

Sort SEE ALSO.

A few suggestions and corrections.

lib/libcasper/services/cap_grp/cap_grp.3
118

s/allows/allow/

maybe: ... which will allow to use the function associated with the name.
or: ... which allows to use the function ... (in this case, allows is fine)

137

That sentence is hard to understand.
Did you mean this:

The field which was set as the limit will be returned else it will be set to default values.

147

Is it just one group or groups (the variable says groups)?

I think you mean to write this:

The cap_grp_limit_groups function allows to limit access to groups.

152

How about this:

The names variable allows to limit groups by name and the gids variable by the group number.

157

The "respectively" has to move at the end, like this:
The names and ngids variables provide numbers of limited names and gids, respectively.

162

s/an/a/

193

s/Umable/Unable/

197

Same here...

201

... and here.

oshogbo added inline comments.
lib/libcasper/services/cap_grp/cap_grp.3
137

So we have a stracture:

struct group {
const char *gr_name;
const char *gr_passwd;
etc.
}

So if i limit it casper to gr_name, I still will get whole structure but only gr_name will be filled from it.

New suggestion on how to word it better, based on your explanation, @oshogbo.
I found something else while there, but it's easy to fix. ;-)

lib/libcasper/services/cap_grp/cap_grp.3
107

Just found this one: s/varlable/variable/

137

Ah, thanks for the explanation.
How about this then:
The field which was set as the limit will be returned, while the rest of the values not set this way will have default values.

brueffer added a subscriber: brueffer.
brueffer added inline comments.
lib/libcasper/services/cap_grp/cap_grp.3
120

Wrong variable? There's no "ntpyes" variable in the signatures above.

191

as we

This revision now requires changes to proceed.Jan 10 2018, 11:05 AM

One more typo, looks good otherwise!

lib/libcasper/services/cap_grp/cap_grp.3
203

associated

This revision now requires changes to proceed.Jan 15 2018, 1:58 PM
oshogbo marked an inline comment as done.

Thank you @brueffer .

This revision is now accepted and ready to land.Jan 25 2018, 8:46 AM
This revision was automatically updated to reflect the committed changes.