Details
- Reviewers
brueffer - Group Reviewers
manpages - Commits
- rS328471: Document the grp Casper service.
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
A few suggestions and corrections.
| lib/libcasper/services/cap_grp/cap_grp.3 | ||
|---|---|---|
| 118 | s/allows/allow/ maybe: ... which will allow to use the function associated with the name. | |
| 137 | That sentence is hard to understand. The field which was set as the limit will be returned else it will be set to default values. | |
| 147 | Is it just one group or groups (the variable says groups)? I think you mean to write this: The cap_grp_limit_groups function allows to limit access to groups. | |
| 152 | How about this: The names variable allows to limit groups by name and the gids variable by the group number. | |
| 157 | The "respectively" has to move at the end, like this: | |
| 162 | s/an/a/ | |
| 193 | s/Umable/Unable/ | |
| 197 | Same here... | |
| 201 | ... and here. | |
| lib/libcasper/services/cap_grp/cap_grp.3 | ||
|---|---|---|
| 137 | So we have a stracture: struct group {
const char *gr_name;
const char *gr_passwd;
etc.
}So if i limit it casper to gr_name, I still will get whole structure but only gr_name will be filled from it. | |
New suggestion on how to word it better, based on your explanation, @oshogbo.
I found something else while there, but it's easy to fix. ;-)
| lib/libcasper/services/cap_grp/cap_grp.3 | ||
|---|---|---|
| 107 | Just found this one: s/varlable/variable/ | |
| 137 | Ah, thanks for the explanation. | |
One more typo, looks good otherwise!
| lib/libcasper/services/cap_grp/cap_grp.3 | ||
|---|---|---|
| 203 | associated | |