Delete the leftover ${WRKSRC}/.metadir directory when 'make install' fails for any reason
Needs ReviewPublic

Authored by yuri on Mon, Jan 8, 6:04 PM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14191
Build 14357: arc lint + arc unit
yuri created this revision.Mon, Jan 8, 6:04 PM
yuri added a comment.Mon, Jan 8, 6:06 PM

This problem happens when during development 'make install' fails due to, for example, a duplicate file conflict.

yuri retitled this revision from Deletes the leftover ${WRKSRC}/.metadir directory when 'make install' fails for any reason to Delete the leftover ${WRKSRC}/.metadir directory when 'make install' fails for any reason.Mon, Jan 8, 10:33 PM
mat added a comment.Tue, Jan 9, 1:08 PM

I don't think this is the right fix.

yuri added a comment.Tue, Jan 9, 6:11 PM
In D13798#289393, @mat wrote:

I don't think this is the right fix.

  1. It accomplishes the cleanup, which is obviously missing in this place
  2. Tests confirm that it solves the original problem.

So, what is exactly not right about it?