www/gitlab: fix Gemfile for updated dependencies

[joneum]

Summary

www/gitlab: fix Gemfile for updated dependencies

PR: 224937
Submitted by: Matthias Fechner <[e-mail]> (maintainer)

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

10.3-amd64
10.3-i386
10.4-amd64
10.4-i386
11.1-amd64
11.1-i386
12.0-CURRENT r325045 amd64
12.0-CURRENT r325045 i386

[tcberner]

Submitted by: Matthias Fechner <[e-mail]> (maintainer)

Approved by: maintainer timeout (2 weeks) xxx (mentor)

this sounds contradictory. If he submitted it, how can he have a timeout?

[tcberner]

You should revert the "changes" to the patches that only chnaged the metadata

www/gitlab/Makefile

256

^ new empty line -- you can get rid of it :D

[tcberner]

www/gitlab/files/patch-config_unicorn.rb.example

8 ↗

(On Diff #37579)

^ for a future review: I think what is wanted here (and in the other patches) is a reinplacement of /home/git/gitlab/ with ${WWWDIR}?

[joneum]

In D13781#288622, @tcberner wrote:

Submitted by: Matthias Fechner <[e-mail]> (maintainer)

Approved by: maintainer timeout (2 weeks) xxx (mentor)

this sounds contradictory. If he submitted it, how can he have a timeout?

copy + paste from a another review .... m

www/gitlab/Makefile

256

i will delete it when commit

[joneum]

.

[tcberner]

r458267 | sunpoet | 2018-01-06 14:51:44 +0100 (Sa., 06 Jan. 2018) | 4 lines

[joneum]

In D13781#288692, @tcberner wrote:

r458267 | sunpoet | 2018-01-06 14:51:44 +0100 (Sa., 06 Jan. 2018) | 4 lines

In D13781#288692, @tcberner wrote:

r458267 | sunpoet | 2018-01-06 14:51:44 +0100 (Sa., 06 Jan. 2018) | 4 lines

???

[tcberner]

In D13781#288693, @joneum wrote:

In D13781#288692, @tcberner wrote:

r458267 | sunpoet | 2018-01-06 14:51:44 +0100 (Sa., 06 Jan. 2018) | 4 lines

In D13781#288692, @tcberner wrote:

r458267 | sunpoet | 2018-01-06 14:51:44 +0100 (Sa., 06 Jan. 2018) | 4 lines

???

I was trying to say @sunpoet already did it.

[joneum]

In D13781#288700, @tcberner wrote:

In D13781#288693, @joneum wrote:

In D13781#288692, @tcberner wrote:

r458267 | sunpoet | 2018-01-06 14:51:44 +0100 (Sa., 06 Jan. 2018) | 4 lines

In D13781#288692, @tcberner wrote:

r458267 | sunpoet | 2018-01-06 14:51:44 +0100 (Sa., 06 Jan. 2018) | 4 lines

???

I was trying to say @sunpoet already did it.

No. This is not the same update. See: https://svnweb.freebsd.org/changeset/ports/458267

[tcberner]

Ah, in that case, could you regenerate the patch quickly, so that it applies again.

[joneum]

In D13781#288705, @tcberner wrote:

Ah, in that case, could you regenerate the patch quickly, so that it applies again.

This is already the new patch, after the commit of sunpoet! ;) (See PORTREVISION-level)

[sunpoet]

When I update a rubygem- port, I'll update gemspec/Gemfile of dependent ports as well. I'll fix Gemfile of gitlab when I update rubygem-jquery-atwho-rails.

[joneum]

https://svnweb.freebsd.org/changeset/ports/458333