Details

usr.bin/morse/morse.c
297–301	I like this re-organization to avoid `#undef` ugliness... Please do mention it in the commit message
345	Can you rename this to `Dflag` to match the case of the flag, given that there's also a -d?
427	Can you throw these tokens in a separate `#define` up above as well? `DELIMITERS` or something to that effect. Also, style(9) spaces around `=`
433	style(9) spaces around `=`
438	Inconsistent omission of braces around single-line clauses
605	Spaces around `=`
614	Spaces around `=`
620	Spaces around `=`
623	Spaces around `=`
626	Spaces around `=`

In D13757#288193, @kevans wrote:

I have some nits to be picked. =p Please don't hate me

Review is great. Why would I hate you. Will fix

Thank you @kevans!

remove testing comment

usr.bin/morse/morse.c
303–304	This doesn't seem to match the given commit message, which indicates that the flag was called -r
439	This one seems to have actually been missed; the braces should be omitted here like on the other one-line blocks.

use err/errx

one of these days....

I reckon this will be the last round. =)

usr.bin/morse/morse.c
349	These left more inconsistent omission of braces for single line blocks, but otherwise also a good change that should be noted in the commit message. =)
353	Here
356	Here
361	Here
369	Here
375	Here
378	Here
541	Here
547	Here

eadler marked 2 inline comments as done.

eadler added inline comments.

usr.bin/morse/morse.c
345	renamed to rflag to match dragongflybsd.
439	I went the reverse: adding braces to all single line blocks. style(9) makes it optional, I prefer it.

eadler marked 12 inline comments as done.Jan 6 2018, 6:42 AM

per @kevans - more {}s

This revision is now accepted and ready to land.Jan 6 2018, 6:52 AM

morse: implement support for decoding morse code
ClosedPublic
Actions