aw_sid: Add man page for this driver
ClosedPublic
Actions

Authored by kevans on Dec 31 2017, 11:07 PM.

Details

Reviewers

manu
jmcneill
bjk
brueffer

Group Reviewers

manpages

Commits

rS327490: aw_sid: Add man page for this driver

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Dec 31 2017, 11:07 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 31 2017, 11:07 PM

Small corrections.

share/man/man4/aw_sid.4
44 ↗	(On Diff #37333)	no space between "strings" and ":"
58 ↗	(On Diff #37333)	same here.

Ok for me but please wait that someone from the manpage group accept it before commiting it.

This revision is now accepted and ready to land.Jan 1 2018, 2:03 PM

brueffer added a subscriber: brueffer.Jan 1 2018, 2:10 PM

brueffer added inline comments.

share/man/man4/aw_sid.4
28 ↗	(On Diff #37333)	We usually spell out the month, so January.
41 ↗	(On Diff #37333)	I'd remove "the current version"; it gets outdated quickly. Ideally the manpage corresponds to the current version of the driver anyway.
61 ↗	(On Diff #37333)	No space before the . at the end.

Address comments by @bcr

This revision now requires review to proceed.Jan 1 2018, 5:24 PM

Thanks for fixing the notes from brueffer; this looks good now.

This revision is now accepted and ready to land.Jan 1 2018, 8:51 PM

Needs one more fix, sorry :-)

share/man/man4/aw_sid.4
58 ↗	(On Diff #37358)	Sorry, just saw this, in this case we need a space between 8 and :, otherwise the : is interpreted as part of the section number.

brueffer requested changes to this revision.Jan 1 2018, 8:56 PM

This revision now requires changes to proceed.Jan 1 2018, 8:56 PM

Whoops, sorry @brueffer, misread your earlier comment as also being by @bcr (and thought it was odd that he came back for a second round of revision before it'd been updated, so that makes more sense now =P). Addressed your last request.