Page MenuHomeFreeBSD

Update bsd.defaults.mk for lua to 5.3 and questions about lua.mk
Needs ReviewPublic

Authored by russ.haley_gmail.com on Dec 30 2017, 7:35 AM.

Details

Reviewers
jbeich
antoine
Group Reviewers
portmgr
Summary

Hi, I saw that the default version of lua is still 5.2 so thought I'd attempt to push that up. I'd also like to ask some questions about the lua.mk file and possibly "clean it up"?

Test Plan

Looking for input.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Mk/Uses/lua.mk
80

So I don't really know if using ${PORTNAME} is valid or not, but wanted to look at standardizing it with the lua ports themselves (at least 5.3 and anything forward). Just looking for input really. How do I test this without modifying my actual ports dir (which I use as a reference)?

antoine requested changes to this revision.Dec 30 2017, 7:47 AM
antoine added a subscriber: antoine.

There was an exp-run a few months ago and the results were bad.
Maybe lua ports could be flavored...

Using ${PORTNAME} in Uses/lua.mk is really wrong.

This revision now requires changes to proceed.Dec 30 2017, 7:47 AM

There was an exp-run a few months ago and the results were bad.
Maybe lua ports could be flavored...

Sorry, could you expand on exp-run and what you mean by flavored?

Using ${PORTNAME} in Uses/lua.mk is really wrong.

I thought it might be but didn't know.

mat added a comment.Dec 30 2017, 8:45 AM

Before the change in default version can go in, an exp-run needs to be requested. See 19.8.5. How can an experimental test build of the ports tree (exp-run) be requested?

russ.haley_gmail.com added a comment.EditedDec 30 2017, 9:10 PM

Much appreciated. I'll start going through these failures. Given that some of these may be "unfixable"/unused/unmaintained, what is the expectation for "pass level" for an exp-run?

Is there any way to cross check how many of these failures build using Lua 5.2? Is is possible/acceptable to pin items to 5.2 that fail and let others use the default?

lzlib for instance is:

Can I ((propose a patch to) pin it to 5.2 (if it builds with 5.2) and allow the dependents to build?

Removed changes to lua.mk. Review is tracking questions on exp-run failures. Alternatively we can close this and I can use bugzilla.

Hi, I've looked over the failures and I think I'd rather just close this review and comment on the original bugzilla ticket. Not sure how to close a review?