Page MenuHomeFreeBSD

Do not lock vm map in swapout_procs().
ClosedPublic

Authored by kib on Dec 29 2017, 7:14 PM.
Tags
None
Referenced Files
F139245234: D13681.id37191.diff
Tue, Dec 9, 10:43 PM
Unknown Object (File)
Tue, Dec 2, 10:13 AM
Unknown Object (File)
Sat, Nov 22, 11:36 PM
Unknown Object (File)
Fri, Nov 21, 11:55 PM
Unknown Object (File)
Fri, Nov 21, 12:53 AM
Unknown Object (File)
Fri, Nov 21, 12:52 AM
Unknown Object (File)
Fri, Nov 21, 12:50 AM
Unknown Object (File)
Fri, Nov 21, 12:49 AM
Subscribers

Details

Summary

Neither swapout_procs() nor swapout() access the map.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Referencing vmspace is useless after vm_map is not accessed.

This revision is now accepted and ready to land.Dec 29 2017, 7:40 PM
This revision was automatically updated to reflect the committed changes.

Hmm. Do we still need to unlock and relock the process?

_PHOLD_LITE(p);
PROC_UNLOCK(p);
sx_sunlock(&allproc_lock);

PROC_LOCK(p);
if (p->p_lock != 1 || (p->p_flag & (P_STOPPED_SINGLE |
    P_TRACED | P_SYSTEM)) != 0)
        goto nextproc;