Page MenuHomeFreeBSD

Do not lock vm map in swapout_procs().
ClosedPublic

Authored by kib on Dec 29 2017, 7:14 PM.
Tags
None
Referenced Files
F108098938: D13681.id37190.diff
Tue, Jan 21, 9:16 AM
Unknown Object (File)
Dec 4 2024, 6:13 PM
Unknown Object (File)
Nov 21 2024, 9:24 PM
Unknown Object (File)
Nov 18 2024, 11:18 PM
Unknown Object (File)
Oct 29 2024, 8:39 AM
Unknown Object (File)
Oct 1 2024, 8:16 PM
Unknown Object (File)
Oct 1 2024, 4:37 PM
Unknown Object (File)
Oct 1 2024, 2:16 PM
Subscribers

Details

Summary

Neither swapout_procs() nor swapout() access the map.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Referencing vmspace is useless after vm_map is not accessed.

This revision is now accepted and ready to land.Dec 29 2017, 7:40 PM
This revision was automatically updated to reflect the committed changes.

Hmm. Do we still need to unlock and relock the process?

_PHOLD_LITE(p);
PROC_UNLOCK(p);
sx_sunlock(&allproc_lock);

PROC_LOCK(p);
if (p->p_lock != 1 || (p->p_flag & (P_STOPPED_SINGLE |
    P_TRACED | P_SYSTEM)) != 0)
        goto nextproc;