Page MenuHomeFreeBSD

Do not lock vm map in swapout_procs().
ClosedPublic

Authored by kib on Dec 29 2017, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 16, 8:46 AM
Unknown Object (File)
Sun, Apr 12, 11:49 PM
Unknown Object (File)
Fri, Apr 10, 11:43 PM
Unknown Object (File)
Fri, Apr 10, 6:07 PM
Unknown Object (File)
Thu, Apr 9, 1:51 AM
Unknown Object (File)
Sun, Apr 5, 7:16 PM
Unknown Object (File)
Wed, Apr 1, 4:36 PM
Unknown Object (File)
Sat, Mar 28, 9:12 PM
Subscribers

Details

Summary

Neither swapout_procs() nor swapout() access the map.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Referencing vmspace is useless after vm_map is not accessed.

This revision is now accepted and ready to land.Dec 29 2017, 7:40 PM
This revision was automatically updated to reflect the committed changes.

Hmm. Do we still need to unlock and relock the process?

_PHOLD_LITE(p);
PROC_UNLOCK(p);
sx_sunlock(&allproc_lock);

PROC_LOCK(p);
if (p->p_lock != 1 || (p->p_flag & (P_STOPPED_SINGLE |
    P_TRACED | P_SYSTEM)) != 0)
        goto nextproc;