Page MenuHomeFreeBSD

Do not lock vm map in swapout_procs().
ClosedPublic

Authored by kib on Dec 29 2017, 7:14 PM.
Tags
None
Referenced Files
F167955000: D13681.id.diff
Tue, Aug 25, 2:59 PM
F167882153: D13681.diff
Tue, Aug 25, 5:47 AM
Unknown Object (File)
Sun, Aug 23, 11:12 PM
Unknown Object (File)
Sun, Aug 23, 6:32 AM
Unknown Object (File)
Sun, Aug 23, 3:03 AM
Unknown Object (File)
Sat, Aug 22, 1:57 PM
Unknown Object (File)
Tue, Aug 18, 4:51 PM
Unknown Object (File)
Tue, Aug 18, 3:34 PM
Subscribers

Details

Summary

Neither swapout_procs() nor swapout() access the map.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Referencing vmspace is useless after vm_map is not accessed.

This revision is now accepted and ready to land.Dec 29 2017, 7:40 PM
This revision was automatically updated to reflect the committed changes.

Hmm. Do we still need to unlock and relock the process?

_PHOLD_LITE(p);
PROC_UNLOCK(p);
sx_sunlock(&allproc_lock);

PROC_LOCK(p);
if (p->p_lock != 1 || (p->p_flag & (P_STOPPED_SINGLE |
    P_TRACED | P_SYSTEM)) != 0)
        goto nextproc;