New port: x11-toolkits/nanogui: Minimalistic GUI library for OpenGL
Needs ReviewPublic

Authored by yuri on Thu, Dec 28, 6:47 PM.

Details

Reviewers
tcberner
adamw
Summary

Minimalistic GUI library for OpenGL

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14402
Build 14554: arc lint + arc unit
yuri created this revision.Thu, Dec 28, 6:47 PM
mat added inline comments.Thu, Dec 28, 10:50 PM
x11-toolkits/nanogui/Makefile
41

Missing EXAMPLES option.

yuri updated this revision to Diff 37169.Thu, Dec 28, 11:57 PM

Added the missing OPTIONS_DEFINE=EXAMPLES.

yuri updated this revision to Diff 37170.Thu, Dec 28, 11:58 PM

Sorry, EXAMPLES were removed.

yuri marked an inline comment as done.Fri, Dec 29, 5:36 PM
tcberner added inline comments.Fri, Dec 29, 10:02 PM
x11-toolkits/nanogui/Makefile
6

^ DISTVERSION

46

^ why not patch the CMakeLists.txt to install this to the proper location driectly -- always seems less dirty to me :D

tcberner added inline comments.Fri, Dec 29, 10:08 PM
x11-toolkits/nanogui/Makefile
46

more importantly.. shouldn't it be nanogui-python.so.

yuri marked 3 inline comments as done.Fri, Dec 29, 10:18 PM
yuri added inline comments.
x11-toolkits/nanogui/Makefile
46

why not patch the CMakeLists.txt

Because the upstream project isn't yet stable, and such patch is likely going to break.

shouldn't it be nanogui-python.so

It does load into python as it is now. Python binding is currently broken, I reported this upstream, but didn't hear back yet. Also, python binding isn't really important for this project, considering its lack of stability and lack of apps using it. It's an experimental part so far,

yuri marked an inline comment as done.Fri, Dec 29, 10:19 PM
tcberner added inline comments.Fri, Dec 29, 10:23 PM
x11-toolkits/nanogui/Makefile
46

if you know it's broken, why install it by default?

mat added inline comments.Fri, Dec 29, 10:46 PM
x11-toolkits/nanogui/Makefile
46

Well, this is exactly why a patch is better than using sed in a post-patch target, or moving things around during post-install.

Because when the file changes enough that the patch does not apply any more, it means you need to check that what you did at the beginning to see if it still applies, or not, or something else need to be done.

When you blindly use sed, you never get noticed that it is obsolete, which is very bad, because it can go on for years, and one day you wonder wtf is these 10 lines of sed doing there that do not do anything at all.

yuri marked an inline comment as done.Fri, Dec 29, 10:51 PM
yuri added inline comments.
x11-toolkits/nanogui/Makefile
46

When you blindly use sed

There is no sed in this case. There is ${MV} in this case. :-)
This ${MV} will break if that file disappeared, or something like that.

yuri marked 3 inline comments as done.Fri, Dec 29, 10:52 PM
yuri added inline comments.
x11-toolkits/nanogui/Makefile
46

I left it "on" because upstream has it "on" by default, also in expectation of it being fixed.

yuri marked 2 inline comments as done.Fri, Dec 29, 10:53 PM
yuri added inline comments.
x11-toolkits/nanogui/Makefile
46

Also, it doesn't break anything else, just breaks itself when run. :)

yuri marked 2 inline comments as done.Sat, Dec 30, 6:32 AM
tcberner added inline comments.Sun, Dec 31, 3:39 PM
x11-toolkits/nanogui/Makefile
19

^ are you sure about this one?

yuri marked an inline comment as done.Sun, Dec 31, 4:39 PM
yuri added inline comments.
x11-toolkits/nanogui/Makefile
19

This is a library using the Eigen headers-only library.
It has a dependency on Eigen in a form of #include statements.
So RUN_DEPENDS here is justified.

yuri updated this revision to Diff 37418.Tue, Jan 2, 7:05 PM
yuri marked an inline comment as done.

Updating for USES=eigen.

yuri marked an inline comment as done.Mon, Jan 8, 10:28 PM
tcberner requested changes to this revision.Mon, Jan 15, 4:07 PM
x11-toolkits/nanogui/Makefile
27

^ This can now be shorter as
CMAKE_OFF=NANOGUI_BUILD_EXAMPLE GLFW_BUILD_EXAMPLES

This revision now requires changes to proceed.Mon, Jan 15, 4:07 PM
yuri updated this revision to Diff 38016.Tue, Jan 16, 12:07 AM
yuri marked an inline comment as done.

CMAKE_OFF