Page MenuHomeFreeBSD

Don't call tcp_lro_rx() unless hardware verified TCP/UDP csum

Authored by shurd on Dec 20 2017, 7:55 PM.



It seems that tcp_lro_rx() doesn't verify TCP checksums, so
if there are bad checksums in the packets caused by invalid data, the
invalid data will pass through without errors.

This was noticed with the igb driver and a specific internet host:
fetch -o test.bin && sha256 test.bin
Would result in a different value sometimes.

This ends up making LRO require RXCSUM to be enabled, and RXCSUM to
support TCP and UDP checksums.

Test Plan

Verify fetch works, run tests with corrupt packet data

Diff Detail

rS FreeBSD src repository - subversion
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This was noted in the FreeBSD Cluster as well. Ensure this Bug is added to the commit.


This revision is now accepted and ready to land.Dec 20 2017, 9:04 PM
This revision was automatically updated to reflect the committed changes.