Page MenuHomeFreeBSD

syscon: Introduce kobj and split out fdt bits
ClosedPublic

Authored by kevans on Dec 17 2017, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 6:02 PM
Unknown Object (File)
Dec 23 2023, 3:15 AM
Unknown Object (File)
Nov 28 2023, 7:06 PM
Unknown Object (File)
Nov 22 2023, 8:45 PM
Unknown Object (File)
Nov 22 2023, 7:19 PM
Unknown Object (File)
Nov 13 2023, 12:15 PM
Unknown Object (File)
Oct 26 2023, 7:39 AM
Unknown Object (File)
Oct 19 2023, 11:40 PM
Subscribers

Details

Summary

Allow more flexibility by kobj'ifying syscon and splitting out fdt specific bits in preparation of a move to the extres framework. The generic fdt driver has been moved to syscon_generic.c and the fdt requirement has been removed from the syscon interface.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Everything else looks OK for me.

sys/dev/syscon/syscon.c
90 ↗(On Diff #36687)

I don't think that we needs/wants default methods for read/write/modify.
Its better to return error, if driver don't implement these.

227 ↗(On Diff #36687)

And whats if single device register multiple syscons? I think that we can store ofw node to struct syscon and then use it for search. OF_device_from_xref() is not right approach I think.
see https://github.com/strejda/tegra/blob/master/sys/dev/extres/phy/phy.c#L93
and its usage.

Something like this, perhaps?

  • Remove default read/write/modify methods
  • Allow creation of syscon node from specific ofw node not necessarily belonging to provider

Re-add context... whoops.

This revision is now accepted and ready to land.Dec 23 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.