ftp/php*-fastdfs: Remake to Master/Slave

[joneum]

Summary

ftp/php*-fastdfs: Remake to Master/Slave Ports

PR: 223714
Submitted by: Daniel Ylitalo <[e-mail]> (maintainer)

Test Plan

#PHP5.6
11.1-amd64
11.1-i386

#PHP7.0
11.1-amd64-PHP70
11.1-i386-PHP70

#PHP7.1
11.1-amd64-PHP71
11.1-i386-PHP71

#PHP7.2
11.1-amd64-PHP72
11.1-i386-PHP72

[tcberner]

You should be able to strip the slave makefiles to

PHP_VER= XX

MASTERDIR=${.CURDIR:H}/php56-fastdfs
.include "${MASTERDIR}/Makefile"

and do the rest in the Mastermakefile

[...]
PHP_VER?= 56   # not set by a slave, so must be master
PHP_VERSIONS_ALL= 56 70 72
IGNORE_WITH_PHP= ${PHP_VERSIONS_ALL:${PHP_VER}}
PKGNAMEPREFIX=php${PHP_VER}-
[...]

ftp/php70-fastdfs/Makefile

5 ↗

(On Diff #36479)

PKGNAMEPREFIX=php${PHP_VER}
this can be set in the master port makefile

7 ↗

(On Diff #36479)

^ you set this in the masters makeifle too.

9 ↗

(On Diff #36479)

^IGNORE_WITH_PHP=${PHP_VERSIONS_ALL:N${PHP_VER}}
you should be able to set something like that in the master makefile (where PHP_VERSIONS_ALL contains what the name says :D )

[joneum]

In D13454#281250, @tcberner wrote:

You should be able to strip the slave makefiles to

PHP_VER= XX

MASTERDIR=${.CURDIR:H}/php56-fastdfs
.include "${MASTERDIR}/Makefile"

and do the rest in the Mastermakefile

[...]
PHP_VER?= 56   # not set by a slave, so must be master
PHP_VERSIONS_ALL= 56 70 72
IGNORE_WITH_PHP= ${PHP_VERSIONS_ALL:${PHP_VER}}
PKGNAMEPREFIX=php${PHP_VER}-
[...]

from the PR:
Torsten Zuehlsdorff freebsd_committer 2017-12-08 13:38:31 UTC

I'm fine with the Master/Slave changes.

Since the ticket is owned by joneum: please go ahead. If testing is fine, i approve the commit.

[tcberner]

Well, if you have the approval of @tz you can go ahead :) -- but you could still try to massage it first a bit =)

[joneum]

I will wait for @tz. You have suggested changes that are useful.

[mat]

ftp/php56-fastdfs/Makefile

7 ↗

(On Diff #36479)

Out of order.

[tz]

In D13454#281259, @joneum wrote:

I will wait for @tz. You have suggested changes that are useful.

Looks fine to me - please go ahead.