libnetbsd: Make the function declaration of efopen() match the definition
ClosedPublic
Actions

Authored by arichardson on Nov 30 2017, 4:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 1:29 AM

	Unknown Object (File)
	Sun, Nov 17, 6:41 PM

	Unknown Object (File)
	Sun, Nov 17, 5:53 PM

	Unknown Object (File)
	Sun, Nov 17, 5:20 PM

	Unknown Object (File)
	Sun, Nov 17, 2:43 PM

	Unknown Object (File)
	Sun, Nov 17, 2:11 PM

	Unknown Object (File)
	Sun, Nov 17, 2:07 PM

	Unknown Object (File)
	Sun, Nov 17, 8:16 AM

View All 63 Files

Subscribers

imp

Details

Reviewers

brooks
emaste

Commits

rS328062: libnetbsd: Make the function declaration of efopen() match the definition

Summary

In order to crossbuild FreeBSD on Mac/Linux I also need to build libnetbsd
and FILE* is not equal to struct __sFILE on those platforms.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13198
Build 13439: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 30 2017, 4:41 PM

I'd guess the upstream version used struct __sFILE to avoid header pollution somewhere, but this seems perfectly fine here.

This revision is now accepted and ready to land.Nov 30 2017, 7:26 PM

emaste accepted this revision.Dec 5 2017, 9:05 PM

Closed by commit rS328062: libnetbsd: Make the function declaration of efopen() match the definition (authored by arichardson). · Explain WhyJan 16 2018, 9:43 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2018, 9:43 PM

Revision Contents
Changeset List

Path

Size

lib/

libnetbsd/

util.h

3 lines

Diff 36007

View Options

libnetbsd: Make the function declaration of efopen() match the definitionClosedPublicActions