Differential D13301

Fix various warnings related to geli support.
ClosedPublic
Actions

Authored by imp on Nov 30 2017, 5:38 AM.

Tags

None

Referenced Files

	F135818469: D13301.id36008.diff
	Thu, Nov 13, 4:38 AM

	Unknown Object (File)
	Mon, Nov 10, 11:15 PM

	Unknown Object (File)
	Fri, Nov 7, 11:40 PM

	Unknown Object (File)
	Thu, Nov 6, 1:09 AM

	Unknown Object (File)
	Wed, Nov 5, 2:25 AM

	Unknown Object (File)
	Mon, Oct 20, 3:35 PM

	Unknown Object (File)
	Mon, Oct 20, 4:16 AM

	Unknown Object (File)
	Oct 1 2025, 7:37 PM

View All 89 Files

Subscribers

Details

Reviewers

emaste
tsoome
dteske
allanjude

Commits

rS326448: Fix all warnings related to geli and ZFS support on x86.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Nov 30 2017, 5:38 AM

Harbormaster completed remote builds in B13192: Diff 35996.Nov 30 2017, 5:38 AM

not, this doesn't fix them all, but fixes most of the worst of them, including crazy pointer manipulation that I can't understand how it ever worked...

imp added inline comments.Nov 30 2017, 5:40 AM

stand/i386/gptboot/gptboot.c
35–37 ↗	(On Diff #35996)	I have a more comprehensive fix for issues like this in the pipeline, but it needs a fair amount more time to cook before it's ready.

Seems good.

This revision is now accepted and ready to land.Nov 30 2017, 6:35 AM

Fix the rest.

This revision now requires review to proceed.Nov 30 2017, 4:54 PM

Herald added a subscriber: delphij. · View Herald TranscriptNov 30 2017, 4:54 PM

Harbormaster completed remote builds in B13199: Diff 36008.Nov 30 2017, 4:54 PM

Thanks for cleaning up my mess

This revision is now accepted and ready to land.Nov 30 2017, 4:59 PM

tsoome accepted this revision.Nov 30 2017, 5:03 PM

Closed by commit rS326448: Fix all warnings related to geli and ZFS support on x86. (authored by imp). · Explain WhyDec 2 2017, 12:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

2 lines

geli/

2 lines

6 lines

i386/

gptboot/

8 lines

libi386/

12 lines

zfsboot/

32 lines

libsa/

1 line

zfs/

3 lines

sys/

cddl/

boot/

zfs/

2 lines

Diff 36082

head/stand/defs.mk

Loading...

head/stand/geli/Makefile

Loading...

head/stand/geli/geliboot.c

Loading...

head/stand/i386/gptboot/gptboot.c

Loading...

head/stand/i386/libi386/biosdisk.c

Loading...

head/stand/i386/zfsboot/zfsboot.c

Loading...

head/stand/libsa/Makefile

Loading...

head/stand/zfs/zfsimpl.c

Loading...

head/sys/cddl/boot/zfs/zfssubr.c

Loading...