Page MenuHomeFreeBSD

VOP_LOOKUP.9: update locking info
ClosedPublic

Authored by asomers on Nov 15 2017, 6:18 PM.
Tags
None
Referenced Files
F170805890: D13108.id35377.diff
Sun, Sep 6, 6:17 PM
F170781350: D13108.id35289.diff
Sun, Sep 6, 2:34 PM
F170758978: D13108.id.diff
Sun, Sep 6, 11:14 AM
Unknown Object (File)
Sat, Sep 5, 8:50 PM
Unknown Object (File)
Sat, Sep 5, 6:43 PM
Unknown Object (File)
Sat, Sep 5, 10:38 AM
Unknown Object (File)
Sat, Sep 5, 6:41 AM
Unknown Object (File)
Sat, Sep 5, 12:01 AM
Subscribers

Details

Summary

VOP_LOOKUP.9: update locking info

Test Plan

This change was originally submitted to our private repo by Will, with a
comment that it originally came from kib. I don't know anything else about it.
If you two still think it's correct, I'll commit it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Yes, the new statement is correct but perhaps is somewhat vague.

You may look at the kern/vnode_if.src to see that we do assert that dvp is locked on VOP_LOOKUP() entry and is kept locked on both successful and erroneous returns. But depending on the arguments, we might upgrade/downgrade the lock as needed.

This revision is now accepted and ready to land.Nov 17 2017, 3:25 PM
This revision was automatically updated to reflect the committed changes.