Page MenuHomeFreeBSD

VOP_LOOKUP.9: update locking info
ClosedPublic

Authored by asomers on Nov 15 2017, 6:18 PM.
Tags
None
Referenced Files
F139221217: D13108.diff
Tue, Dec 9, 2:59 PM
Unknown Object (File)
Thu, Nov 27, 9:01 PM
Unknown Object (File)
Wed, Nov 26, 5:18 PM
Unknown Object (File)
Mon, Nov 24, 8:56 PM
Unknown Object (File)
Sat, Nov 22, 4:20 PM
Unknown Object (File)
Fri, Nov 21, 2:18 AM
Unknown Object (File)
Fri, Nov 21, 2:15 AM
Unknown Object (File)
Fri, Nov 21, 2:12 AM
Subscribers

Details

Summary

VOP_LOOKUP.9: update locking info

Test Plan

This change was originally submitted to our private repo by Will, with a
comment that it originally came from kib. I don't know anything else about it.
If you two still think it's correct, I'll commit it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Yes, the new statement is correct but perhaps is somewhat vague.

You may look at the kern/vnode_if.src to see that we do assert that dvp is locked on VOP_LOOKUP() entry and is kept locked on both successful and erroneous returns. But depending on the arguments, we might upgrade/downgrade the lock as needed.

This revision is now accepted and ready to land.Nov 17 2017, 3:25 PM
This revision was automatically updated to reflect the committed changes.