Page MenuHomeFreeBSD

comms/qt5-serialbus: Build the entire code instead of just src/serialbus
ClosedPublic

Authored by rakuco on Nov 15 2017, 5:29 PM.

Details

Summary

I don't really know/remember why the port was added this way, but there is no reason not to build the entire thing: qtserialbus has its own tarball and I guess it is more useful with the canbus plugin that we installing now.

Test Plan

Built fine.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Canbus was left out in 5.6.1, as it was/is? not supported on FreeBSD -- but as it will make life easier for the upgrade, please go ahead.

comms/qt5-serialbus/pkg-plist
65
%%DEBUG%%%%QT_PLUGINDIR%%/canbus/libqtpeakcanbus.so.debug
%%DEBUG%%%%QT_PLUGINDIR%%/canbus/libqttinycanbus.so.debug
adridg added a subscriber: adridg.

tcberner@ points out some missing %%DEBUG%%, but otherwise looks ok. The CAN bus code probably useless, but there's nothing there that is weird or uncompilable.

This revision is now accepted and ready to land.Nov 19 2017, 9:41 PM
This revision was automatically updated to reflect the committed changes.