Page MenuHomeFreeBSD

CXGBE: fix get_filt to be endianness-aware
ClosedPublic

Authored by wma on Nov 15 2017, 12:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 2:36 PM
Unknown Object (File)
Mon, Oct 6, 2:03 AM
Unknown Object (File)
Tue, Sep 16, 10:20 AM
Unknown Object (File)
Sep 12 2025, 2:00 AM
Unknown Object (File)
Sep 9 2025, 11:52 PM
Unknown Object (File)
Aug 15 2025, 8:18 AM
Unknown Object (File)
Jul 18 2025, 10:12 PM
Unknown Object (File)
Jul 4 2025, 5:06 AM
Subscribers

Details

Summary
Unconditional 32-bit shift is not endianness-safe.
Modify the logic to work both on LE and BE.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Have you tested this change on x86 to make sure it still works on LE hardware? It looks ok but it would be nice to test...

Just tested on arm64 (LE), works fine.

This revision is now accepted and ready to land.Jan 9 2018, 8:19 PM
This revision was automatically updated to reflect the committed changes.