CXGBE: fix get_filt to be endianness-aware
ClosedPublic
Actions

Authored by wma on Nov 15 2017, 12:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 16, 8:33 AM

	Unknown Object (File)
	Thu, Nov 14, 2:31 PM

	Unknown Object (File)
	Mon, Oct 28, 12:24 PM

	Unknown Object (File)
	Oct 4 2024, 12:29 PM

	Unknown Object (File)
	Oct 3 2024, 8:03 PM

	Unknown Object (File)
	Oct 1 2024, 6:12 PM

	Unknown Object (File)
	Sep 30 2024, 10:09 AM

	Unknown Object (File)
	Sep 28 2024, 10:30 AM

View All 38 Files

Subscribers

imp

Details

Reviewers

np
nwhitehorn
mw

Commits

rS327811: CXGBE: fix get_filt to be endianness-aware

Summary

Unconditional 32-bit shift is not endianness-safe.
Modify the logic to work both on LE and BE.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wma created this revision.Nov 15 2017, 12:55 PM

Herald added subscribers: ae, imp. · View Herald TranscriptNov 15 2017, 12:55 PM

Have you tested this change on x86 to make sure it still works on LE hardware? It looks ok but it would be nice to test...

Just tested on arm64 (LE), works fine.

np accepted this revision.Jan 9 2018, 8:19 PM

This revision is now accepted and ready to land.Jan 9 2018, 8:19 PM

Closed by commit rS327811: CXGBE: fix get_filt to be endianness-aware (authored by wma). · Explain WhyJan 11 2018, 9:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

cxgbe/

t4_sge.c

8 lines

Diff 37786

View Options

head/sys/dev/cxgbe/t4_sge.c

CXGBE: fix get_filt to be endianness-awareClosedPublicActions