Page MenuHomeFreeBSD
Differential D13084

CXGBE: fix big-endian behaviour
ClosedPublic
Actions

Authored by wma on Nov 14 2017, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 20, 1:23 PM
Unknown Object (File)
Tue, Aug 18, 5:32 AM
Unknown Object (File)
Fri, Aug 14, 5:25 AM
Unknown Object (File)
Wed, Aug 12, 1:58 PM
Unknown Object (File)
Tue, Aug 11, 10:03 AM
Unknown Object (File)
Tue, Aug 11, 9:04 AM
Unknown Object (File)
Mon, Aug 10, 12:50 AM
Unknown Object (File)
Fri, Aug 7, 9:45 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
np
nwhitehorn
mw
Commits
rS339396: MFC r325840, r327811, and r329701.
rS325840: CXGBE: fix big-endian behaviour
Summary

The setbit/clearbit pair casts the bitfield pointer

to uint8_t* which effectively treats its contents as
little-endian variable. The ffs() function accepts int as
the parameter, which is big-endian. Use uint8_t here to
avoid mismatch, as we have only 4 doorbells.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wma created this revision.Nov 14 2017, 1:18 PM
Herald added subscribers: ae, imp. · View Herald TranscriptNov 14 2017, 1:18 PM
np accepted this revision.Nov 14 2017, 4:54 PM

Can you please verify that the output of "sysctl dev.t6nex.0.doorbells " looks ok before commiting this? It should show the names of the bits and not just the numeric value.

This revision is now accepted and ready to land.Nov 14 2017, 4:54 PM
wma added a comment.Nov 15 2017, 6:45 AM

Yes, sysctl shows all doorbells just fine

root@:~ # sysctl dev.t6nex.0.doorbells
dev.t6nex.0.doorbells: 9<UDB,KDB>
root@:~ #

Closed by commit rS325840: CXGBE: fix big-endian behaviour (authored by wma). · Explain WhyNov 15 2017, 6:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
cxgbe/
6 lines

Diff 35267

View Options

head/sys/dev/cxgbe/adapter.h

Loading...