Page MenuHomeFreeBSD

CXGBE: fix big-endian behaviour
ClosedPublic

Authored by wma on Nov 14 2017, 1:18 PM.
Tags
None
Referenced Files
F137085842: D13084.id35267.diff
Fri, Nov 21, 2:57 AM
F137077697: D13084.id35231.diff
Fri, Nov 21, 2:38 AM
F137077298: D13084.id.diff
Fri, Nov 21, 2:37 AM
F137076998: D13084.diff
Fri, Nov 21, 2:36 AM
Unknown Object (File)
Mon, Nov 10, 12:50 AM
Unknown Object (File)
Sat, Oct 25, 5:13 PM
Unknown Object (File)
Sat, Oct 25, 5:13 PM
Unknown Object (File)
Sat, Oct 25, 5:13 PM
Subscribers

Details

Summary

The setbit/clearbit pair casts the bitfield pointer

to uint8_t* which effectively treats its contents as
little-endian variable. The ffs() function accepts int as
the parameter, which is big-endian. Use uint8_t here to
avoid mismatch, as we have only 4 doorbells.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Can you please verify that the output of "sysctl dev.t6nex.0.doorbells " looks ok before commiting this? It should show the names of the bits and not just the numeric value.

This revision is now accepted and ready to land.Nov 14 2017, 4:54 PM

Yes, sysctl shows all doorbells just fine

root@:~ # sysctl dev.t6nex.0.doorbells
dev.t6nex.0.doorbells: 9<UDB,KDB>
root@:~ #

This revision was automatically updated to reflect the committed changes.