Page MenuHomeFreeBSD

CXGBE: fix big-endian behaviour
ClosedPublic

Authored by wma on Nov 14 2017, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 3, 3:52 PM
Unknown Object (File)
Nov 29 2024, 2:18 PM
Unknown Object (File)
Nov 15 2024, 8:12 PM
Unknown Object (File)
Oct 9 2024, 1:50 AM
Unknown Object (File)
Sep 22 2024, 6:55 PM
Unknown Object (File)
Sep 14 2024, 5:58 PM
Unknown Object (File)
Sep 8 2024, 7:39 PM
Unknown Object (File)
Sep 8 2024, 12:24 PM
Subscribers

Details

Summary

The setbit/clearbit pair casts the bitfield pointer

to uint8_t* which effectively treats its contents as
little-endian variable. The ffs() function accepts int as
the parameter, which is big-endian. Use uint8_t here to
avoid mismatch, as we have only 4 doorbells.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Can you please verify that the output of "sysctl dev.t6nex.0.doorbells " looks ok before commiting this? It should show the names of the bits and not just the numeric value.

This revision is now accepted and ready to land.Nov 14 2017, 4:54 PM

Yes, sysctl shows all doorbells just fine

root@:~ # sysctl dev.t6nex.0.doorbells
dev.t6nex.0.doorbells: 9<UDB,KDB>
root@:~ #

This revision was automatically updated to reflect the committed changes.